reply: remove content-length when Transfer-Encoding is added#3814
Merged
mcollina merged 1 commit intofastify:mainfrom Apr 2, 2022
Merged
reply: remove content-length when Transfer-Encoding is added#3814mcollina merged 1 commit intofastify:mainfrom
mcollina merged 1 commit intofastify:mainfrom
Conversation
Member
|
After testing, it is actually not. |
delvedor
approved these changes
Apr 2, 2022
| // < 200. | ||
| // < 200 | ||
| // A sender MUST NOT send a Content-Length header field in any message | ||
| // that contains a Transfer-Encoding header field. |
Member
There was a problem hiding this comment.
Suggested change
| // that contains a Transfer-Encoding header field. | |
| // that contains a Transfer-Encoding header field. | |
| // See: https://tools.ietf.org/html/rfc7230#section-3.3.2 |
Contributor
Author
There was a problem hiding this comment.
This url has been added at the first line of this code comments
Member
|
Can you send a backport PR to v3.x? It did not update automatically |
Member
|
Actually no need! |
4 tasks
Contributor
Author
|
@climba03003 Thanks for your rebase |
mcollina
pushed a commit
that referenced
this pull request
Apr 4, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to https://tools.ietf.org/html/rfc7230#section-3.3.2
Checklist
npm run testandnpm run benchmarkand the Code of conduct