Conversation
956c65b to
6bed074
Compare
6bed074 to
47a8c48
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤦♂️ #3717 didn't quite do what I intended. It failed to upload an artifact if coverage was not met -- https://github.com/fastify/fastify/runs/5267302531?check_suite_focus=true
This PR tweaks the
coverage:ciscript to not check the coverage and adds a new script that explicitly checks the coverage. This gives us 1. the uploading of the desired artifact and 2. prevention of running further workflows when coverage is not met.This run shows that the the workflows are doing as outlined above -- https://github.com/fastify/fastify/actions/runs/1873437127
Checklist
npm run testandnpm run benchmarkand the Code of conduct