Skip to content

Fix coverage workflows#3719

Merged
mcollina merged 1 commit intomainfrom
fix-coverage-workflow
Feb 21, 2022
Merged

Fix coverage workflows#3719
mcollina merged 1 commit intomainfrom
fix-coverage-workflow

Conversation

@jsumners
Copy link
Member

@jsumners jsumners commented Feb 20, 2022

🤦‍♂️ #3717 didn't quite do what I intended. It failed to upload an artifact if coverage was not met -- https://github.com/fastify/fastify/runs/5267302531?check_suite_focus=true

This PR tweaks the coverage:ci script to not check the coverage and adds a new script that explicitly checks the coverage. This gives us 1. the uploading of the desired artifact and 2. prevention of running further workflows when coverage is not met.

This run shows that the the workflows are doing as outlined above -- https://github.com/fastify/fastify/actions/runs/1873437127

Checklist

@jsumners jsumners force-pushed the fix-coverage-workflow branch from 956c65b to 6bed074 Compare February 20, 2022 23:44
@jsumners jsumners force-pushed the fix-coverage-workflow branch from 6bed074 to 47a8c48 Compare February 20, 2022 23:49
@jsumners jsumners marked this pull request as ready for review February 20, 2022 23:49
@jsumners jsumners mentioned this pull request Feb 21, 2022
2 tasks
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 39661e6 into main Feb 21, 2022
@mcollina mcollina deleted the fix-coverage-workflow branch February 21, 2022 08:24
@jsumners jsumners mentioned this pull request Jul 8, 2023
2 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants