Conversation
fc81d6f to
ec300d4
Compare
1ee626a to
df90892
Compare
df90892 to
5e8a41a
Compare
Eomm
reviewed
Feb 20, 2022
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, our CI code coverage reporting depends upon the unit tests succeeding. Which means if a unit run fails, no coverage report is uploaded to Coveralls for that suite. When the suite fails due to missing coverage, we have no easy way of seeing what coverage loss generated the error. In particular, non-Windows people cannot see the coverage report in https://github.com/fastify/fastify/runs/5259373178?check_suite_focus=true
This pull request adds a new step to our CI that generates coverage reports subsequent to linting and prior to unit testing. The result of this coverage report will be attached to the Actions panel for the CI run as a zip file. This zip file can be downloaded and explored with a web browser.
I think this step could also be used to generate an
lcovfile to upload to Coveralls and thus skip the final Coveralls step. But I'm not sure how to accomplish that with the various OS and Node.js matrices we use along with Coveralls's "parallel" feature. Probably not worth the effort to figure it out, so I haven't.The coverage reports generated by this new CI flow target the current Node.js LTS only. This is done to simply the setup, and reduce the CI run time.
This PR also tweaks a couple items in the
ci.ymlto speed up multiple runs within a single PR lifecycle, and to use the LTS version of Node in the jobs where we were using a single Node version.Checklist
npm run testandnpm run benchmarkand the Code of conduct