Skip to content

Conversation

@xtx1130
Copy link
Contributor

@xtx1130 xtx1130 commented Jul 25, 2019

change async hooks judgment, from warning to error

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@Eomm Eomm added the v3.x Issue or pr related to Fastify v3 label Jul 25, 2019
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added enhancement semver-major Issue or PR that should land as semver major labels Jul 27, 2019
@delvedor delvedor merged commit 92cd542 into fastify:next Jul 27, 2019
Eomm pushed a commit to Eomm/fastify that referenced this pull request Nov 24, 2019
…1766)

* chore: change async hooks warning to error

* test: change test case for 'change async hooks warning to error'
@mcollina mcollina mentioned this pull request Nov 24, 2019
4 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
@Eomm Eomm added the semver-minor Issue or PR that should land as semver minor label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver-major Issue or PR that should land as semver major semver-minor Issue or PR that should land as semver minor v3.x Issue or pr related to Fastify v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants