Would you mind removing the greenkeeper block? Those should get automatically updated.

Note that only packages that need to be updated now (currently) are: tap, tap-mocha-reporter, and then remove joi and tap-mocha-reporter from greenkeeper ignore list).

If I update both to latest I have some errors during tests:

  test: test/internals/initialConfig.test.js Original options must not be altered
    (test deep cloning)
  stack: |
    Test.t (test/internals/initialConfig.test.js:201:5)
...
  test: test/internals/initialConfig.test.js Original options must not be altered
    (test deep cloning)
  stack: |
    Test.t (test/internals/initialConfig.test.js:202:5)

I think we should update and fix them (if it's something in Fastify code) ... but to let you know I should commit with '--force' so we can see here from CI builds, ok ?
Last, for the fixes, do you have some suggestions ?

Thanks a lot.

I you should also update joi to @hapi/joi.

I think we should update and fix them (if it's something in Fastify code) ... but to let you know I should commit with '--force' so we can see here from CI builds, ok ?

I don't understand. Use --force  as you please, we'll squash the commits on landing.

@mcollina reply inline

I you should also update joi to @hapi/joi.

done, thanks for the hint

I don't understand. Use --force as you please, we'll squash the commits on landing.

if I commit the upgrade even of Tap and related other library, there are some tests which fails, so to commit/push I need to skip pre-commit hook failures ... but in this way I can show to you the problem, makes sense ?

git commit -n

it skips the pre-commit hooks

@mcollina commit even updates to latest version for tap and tap-mocha-reporter (skipping pre-commit hook), so you can see CI failure in some tests ... let's update soon because I'll need some help understanding if/what/how we need to fix something. Thanks for now. Bye

I would recommend passing the ‘--no-esm’ option to tap. It might be related to that.

I would recommend passing the ‘--no-esm’ option to tap. It might be related to that.

sorry but even with that flag I see same errors ...

I would change those two lines:

I would change those two lines:

fastify/test/internals/initialConfig.test.js

Lines 201 to 202 in 25d822b

	t.deepEqual(originalOptions.https.key, originalOptionsClone.https.key)
	t.deepEqual(originalOptions.https.cert, originalOptionsClone.https.cert)

to compare the base64 of those. I think for some reasons comparing two buffers have changed behavior.

ok, I'll try to do it and keep you updated, thanks for the suggestion

We can land if CI is happy.

I still see a problem with Windows_yarm node_10_x and Windows_yarm node_12_x, it seems a timeout problem; later today I'll squash the branch to see if all builds are successful

@mcollina all done :-) . Bye

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.