Skip to content

remove travis from next branch #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Eomm merged 4 commits into from
Jun 1, 2019
Merged

remove travis from next branch #1670

Eomm merged 4 commits into from
Jun 1, 2019

Conversation

@Ethan-Arrowood
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood commented May 23, 2019

Closes #1658

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Eomm
Eomm approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove Travis access to this repository after the merge also?

mcollina
mcollina requested changes May 24, 2019
View reviewed changes
@mcollina
Copy link
Member

mcollina commented May 24, 2019

Can you also do a similar PR for v1?

@mcollina
Copy link
Member

mcollina commented May 24, 2019

I would like @jsumners to have full access before we land this: #1658 (comment).

@jsumners
Copy link
Member

jsumners commented May 24, 2019

Please don't let me hold you up on whatever CI integration. I have personal issues with using the Azure CI product and will likely never again bother trying to login.

@Ethan-Arrowood Ethan-Arrowood mentioned this pull request May 24, 2019
Closed
@delvedor delvedor added the chore Small changes or internal project maintenance label May 24, 2019
delvedor
delvedor reviewed May 24, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker: #1671

@Ethan-Arrowood
Copy link
Member Author

Ethan-Arrowood commented May 29, 2019

#1671 is now solved 👍

@Ethan-Arrowood Ethan-Arrowood changed the title remove travis remove travis from next branch May 29, 2019
@Ethan-Arrowood Ethan-Arrowood mentioned this pull request May 29, 2019
Merged
13 tasks
@Ethan-Arrowood
Copy link
Member Author

Ethan-Arrowood commented May 30, 2019 •
edited
Loading

Rebase after #1682 lands. Create similar 1.x pr after #1683 lands.

@Ethan-Arrowood Ethan-Arrowood added the backport 1.x Issue or pr that should be backported to Fastify v1 label May 31, 2019
@Ethan-Arrowood
Copy link
Member Author

Ethan-Arrowood commented May 31, 2019

After CI this is ready to go along with the backport #1685

mcollina
mcollina approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina requested changes May 31, 2019
View reviewed changes
mcollina
mcollina approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm Eomm merged commit 9865808 into fastify:next Jun 1, 2019
@delvedor delvedor mentioned this pull request Jun 24, 2019
Closed
Eomm pushed a commit to Eomm/fastify that referenced this pull request Nov 24, 2019
@Ethan-Arrowood @Eomm
remove travis from next branch (fastify#1670)
ebed766
@mcollina mcollina mentioned this pull request Nov 24, 2019
Closed
4 tasks
@github-actions
Copy link

github-actions bot commented Feb 10, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

@Eomm Eomm Eomm approved these changes

Assignees

No one assigned

Labels

backport 1.x Issue or pr that should be backported to Fastify v1 chore Small changes or internal project maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ethan-Arrowood @mcollina @jsumners @delvedor @Eomm