-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Updated azure pipelines configuration #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added macOS - Test both yarn and npm on every system - Improve readability of the configuration files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see macOS on the pipeline! LGTM 🚀 is there an existing run of this where everything is passing?
-- Edit
Looks like the PR used this new configuration as I see the macOs_yarn and macOs_npm GitHub checks 🎉
Eomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIK mac and linux shouldn't have big differences, but for sure this test suite is the most complete ever!
In this way we are testing also our dep across all these OS and package manager, so we must be conscious that in future there could be some flaky tests
|
I would move the templates in the build/ folder. Good work. I think we can remove travis. |
Let's do that in a separate pr. I'll merge this as-is. |
* Updated azure pipelines configuration - Added macOS - Test both yarn and npm on every system - Improve readability of the configuration files * Move azure templates inside the build folder
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Note: Do not merge yet, the aim of this pr is to see if it is worth to have such a big testing pipeline.
Checklist
npm run testandnpm run benchmark