Skip to content

Conversation

@delvedor
Copy link
Member

@delvedor delvedor commented May 9, 2019

  • Added macOS
  • Test both yarn and npm on every system
  • Improve readability of the configuration files

Note: Do not merge yet, the aim of this pr is to see if it is worth to have such a big testing pipeline.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

- Added macOS
- Test both yarn and npm on every system
- Improve readability of the configuration files
@delvedor delvedor added chore Small changes or internal project maintenance test Issue or pr related to our testing infrastructure. labels May 9, 2019
@delvedor delvedor requested a review from a team May 9, 2019 12:30
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see macOS on the pipeline! LGTM 🚀 is there an existing run of this where everything is passing?

-- Edit
Looks like the PR used this new configuration as I see the macOs_yarn and macOs_npm GitHub checks 🎉

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIK mac and linux shouldn't have big differences, but for sure this test suite is the most complete ever!

In this way we are testing also our dep across all these OS and package manager, so we must be conscious that in future there could be some flaky tests

@mcollina
Copy link
Member

mcollina commented May 9, 2019

I would move the templates in the build/ folder.

Good work. I think we can remove travis.

@delvedor
Copy link
Member Author

Good work. I think we can remove travis.

Let's do that in a separate pr. I'll merge this as-is.

@delvedor delvedor merged commit 86d868a into master May 11, 2019
@delvedor delvedor deleted the update-pipeline branch May 11, 2019 10:08
mcollina pushed a commit that referenced this pull request May 31, 2019
* Updated azure pipelines configuration
- Added macOS
- Test both yarn and npm on every system
- Improve readability of the configuration files

* Move azure templates inside the build folder
mcollina added a commit that referenced this pull request May 31, 2019
* Updated azure pipelines configuration
- Added macOS
- Test both yarn and npm on every system
- Improve readability of the configuration files

* Move azure templates inside the build folder
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Small changes or internal project maintenance test Issue or pr related to our testing infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants