-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update tap to the latest version 🚀 #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
|
|
|
|
For Your Info: in fastify-example I had some problems with the upgrade to Tap 13.x, but with with today release (13.1.8) all has been solved (thanks to the help Tap guys gave me), but I had to add in npm custom commands the flag '--no-esm', no sure it will be needed even here. @mcollina @delvedor I can do some check, but for a PR (if needed) on which branch, a new one to arget this or from/to master ? Thanks. Bye, Sandro |
|
@smartiniOnGitHub tap v13 has dropped node v6 (that we are still supporting), so we can't upgrade this dev-dept. In this case we should add |
|
@Eomm ok I can do, in a new PR for that change, right ? |
Yes 👍
Yes also here
Nope, I'm not sure, but I think the leads will open it to discuss and define the tasks in future. (for notice: there are already some issue with the v3 label) |
Yes we'll drop Node 6 then. |
|
@mcollina Ciao Matteo, sure but maybe before a PR an issue would be good, to better define what it means ? At the moment I think of: removing it from all CI systems, update docs, etc but maybe there are some code portions that should be updated too (and for this I'm not aware). Thanks for now. Bye |
|
All of that, plus removing some of the conditionals for async/await and http2 in the tests. |
|
Hi all, PR done: #1643 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The devDependency tap was updated from
12.7.0to13.1.1.This version is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
Find out more about this release.
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴