Skip to content

Conversation

@greenkeeper
Copy link
Contributor

@greenkeeper greenkeeper bot commented Apr 29, 2019

The devDependency tap was updated from 12.7.0 to 13.1.1.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Find out more about this release.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 1, 2019

  • The devDependency tap was updated from 12.7.0 to 13.1.2.

Update to this version instead 🚀

Commits

The new version differs by 2 commits.

  • 261edb5 13.1.2
  • a1e4107 Use yaml instead of util.format for repl/watch outputs

See the full diff

greenkeeper bot added a commit that referenced this pull request May 1, 2019
greenkeeper bot added a commit that referenced this pull request May 8, 2019
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 8, 2019

  • The devDependency tap was updated from 12.7.0 to 13.1.3.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request May 8, 2019
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 8, 2019

  • The devDependency tap was updated from 12.7.0 to 13.1.5.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request May 9, 2019
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 9, 2019

  • The devDependency tap was updated from 12.7.0 to 13.1.6.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request May 10, 2019
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 10, 2019

  • The devDependency tap was updated from 12.7.0 to 13.1.7.

Update to this version instead 🚀

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 11, 2019

  • The devDependency tap was updated from 12.7.0 to 13.1.8.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request May 11, 2019
@smartiniOnGitHub
Copy link
Contributor

For Your Info: in fastify-example I had some problems with the upgrade to Tap 13.x, but with with today release (13.1.8) all has been solved (thanks to the help Tap guys gave me), but I had to add in npm custom commands the flag '--no-esm', no sure it will be needed even here.

@mcollina @delvedor I can do some check, but for a PR (if needed) on which branch, a new one to arget this or from/to master ?
Last in my test commands I force even a '--strict' flag, do you think it would be useful even here ?

Thanks. Bye, Sandro

@Eomm
Copy link
Member

Eomm commented May 12, 2019

@smartiniOnGitHub tap v13 has dropped node v6 (that we are still supporting), so we can't upgrade this dev-dept.

In this case we should add tap in the greenkeeper ignore list (in package.json) and close this PR
Would you like to do so?

@smartiniOnGitHub
Copy link
Contributor

@Eomm ok I can do, in a new PR for that change, right ?
Last, sorry for next major release (3.x, should be in a 'next' branch or similar) there should be already a plan to remove Node.js 6.x, right ? Or an issue is needed ?

@Eomm
Copy link
Member

Eomm commented May 12, 2019

ok I can do, in a new PR for that change, right ?

Yes 👍

there should be already a plan to remove Node.js 6.x, right ?

Yes also here

Or an issue is needed ?

Nope, I'm not sure, but I think the leads will open it to discuss and define the tasks in future. (for notice: there are already some issue with the v3 label)

@mcollina
Copy link
Member

Last, sorry for next major release (3.x, should be in a 'next' branch or similar) there should be already a plan to remove Node.js 6.x, right ? Or an issue is needed ?

Yes we'll drop Node 6 then.
I've cut a new branch next. Would you like to send a PR?

@smartiniOnGitHub
Copy link
Contributor

@mcollina Ciao Matteo, sure but maybe before a PR an issue would be good, to better define what it means ? At the moment I think of: removing it from all CI systems, update docs, etc but maybe there are some code portions that should be updated too (and for this I'm not aware). Thanks for now. Bye

@mcollina
Copy link
Member

All of that, plus removing some of the conditionals for async/await and http2 in the tests.

@smartiniOnGitHub
Copy link
Contributor

smartiniOnGitHub commented May 13, 2019

Hi all, PR done: #1643
In next days I'll the other (maybe even the removal of some dependencies in GreenKeeper to target as minimum Node.js 8.x in the 'next' branch) ... Bye

@Eomm Eomm closed this May 13, 2019
@Eomm Eomm deleted the greenkeeper/tap-13.1.1 branch May 13, 2019 20:33
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants