Merged
Conversation
jsumners
added a commit
that referenced
this pull request
Jun 23, 2024
* Update for v5 (#80) * update * up * workflows: update and pin node LTS versions (#81) * update workflow * start from 16 * perf: make ipv4 regex faster (#73) * perf: make ipv4 regex faster All credits for this regex to https://stackoverflow.com/a/36760050. The regex is both more correct and faster (https://esbench.com/bench/6532596e7ff73700a4debb6a). Examples: previous regex recognized "01.01.01.01" or "1.1.000.1" as correct ipv4 regex, but those aren't valid as per https://datatracker.ietf.org/doc/html/rfc5954#section-4.1. * avoid capture groups * update to fastest regexp variant * comment out 10.10.000.1110 * lint --------- Signed-off-by: Jacob Groß <kurtextrem@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> --------- Signed-off-by: Jacob Groß <kurtextrem@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: Jacob Groß <kurtextrem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.