Skip to content

Update for Fastify v5#34

Merged
gurgunday merged 4 commits intofastify:nextfrom
synapse:next
Apr 14, 2024
Merged

Update for Fastify v5#34
gurgunday merged 4 commits intofastify:nextfrom
synapse:next

Conversation

@synapse
Copy link
Contributor

@synapse synapse commented Mar 22, 2024

Ref: fastify/fastify#5116

Checklist

CC @simoneb

@simoneb simoneb changed the base branch from master to next March 22, 2024 08:57
@simoneb
Copy link

simoneb commented Mar 22, 2024

done

@synapse
Copy link
Contributor Author

synapse commented Mar 25, 2024

Hey @gurgunday there's seem to be an issue with yarn and tap v18. From what I can see when running the tests with yarn (even locally) that tap has some missing TS types missing 🤔 ?

src/index.ts:33:25 - error TS2307: Cannot find module 'node:util' or its corresponding type declarations.

33 import { inspect } from 'node:util'
                           ~~~~~~~~~~~
Found 1 error in src/index.ts:33

writing tsconfig files...
using existing tsconfig.json
building /.../deepmerge/node_modules/@tapjs/test/test-built

The deepmerge repo does not import node:util directly so it seems that either yarn is not up to date with typescript or tap has something missing there.
Do you have any ideas on how to fix this?

@gurgunday
Copy link
Member

I've never used Yarn so...

Personally, I don't know why we're testing for different package managers here

I'll try to take a look but it would be appreciated if someone from @fastify/libraries could lend a hand

@gurgunday
Copy link
Member

gurgunday commented Apr 12, 2024

I don't have the time to investigate this, and I really want us to drop support for node v14 at this point

Third-party package manager support should be a best effort thing, we cannot be the ones trying to make them all work...

@gurgunday gurgunday requested review from a team and Fdawgs April 12, 2024 20:41
@gurgunday gurgunday merged commit f6e1fee into fastify:next Apr 14, 2024
jsumners added a commit that referenced this pull request Jun 23, 2024
* Update for Fastify v5 (#34)

* update for fastify 5

* fixed typescript issue

* updated plugins-ci-package-manager

* remove package manager ci

---------

Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>

* update workflow and pin node versions (#36)

---------

Co-authored-by: Cristian Barlutiu <cristian.barlutiu@gmail.com>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants