Add click 8.1.0 support by zanieb · Pull Request #375 · fastapi/typer

zanieb · 2022-03-28T18:07:55Z

Some deprecated code was removed in pallets/click#2130 resulting in the failed import of get_terminal_size from click. Per the recommendation in Click's release notes, we can import from shutil instead.

get_terminal_size can probably be dropped from Typer's interface in the future since it's been dropped from Click's, but I'll leave that decision to a future PR. This change is backwards compatible.

See https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0
Closes #377

jepler · 2022-03-28T19:25:36Z

Thanks! This looks like a correct fix.

genos · 2022-03-29T00:44:01Z

I came to after experiencing the aforementioned bug just this afternoon, only to find y'all already had a fix in the works. Thanks!

Ravi4moreyeahs · 2022-03-29T04:23:04Z

Traceback (most recent call last):
File "/Users/moreyeahs/CheQ ONE/Dockerized/app/main.py", line 17, in
from bank.default import DefaultPatern
File "/Users/moreyeahs/CheQ ONE/Dockerized/app/bank/default.py", line 2, in
import spacy
File "/Users/moreyeahs/CheQ ONE/Dockerized/venv/lib/python3.10/site-packages/spacy/init.py", line 15, in
from .cli.info import info # noqa: F401
File "/Users/moreyeahs/CheQ ONE/Dockerized/venv/lib/python3.10/site-packages/spacy/cli/init.py", line 3, in
from ._util import app, setup_cli # noqa: F401
File "/Users/moreyeahs/CheQ ONE/Dockerized/venv/lib/python3.10/site-packages/spacy/cli/_util.py", line 9, in
import typer
File "/Users/moreyeahs/CheQ ONE/Dockerized/venv/lib/python3.10/site-packages/typer/init.py", line 12, in
from click.termui import get_terminal_size as get_terminal_size
ImportError: cannot import name 'get_terminal_size' from 'click.termui'

danielbraun89 · 2022-03-29T07:28:21Z

This is a high priority bug fix! all new installations of typer are basically broken

In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375

jepler · 2022-03-29T16:12:42Z

If there's any way Adafruit can help get this merged and a release made, please @ me!

austinbutler · 2022-03-29T21:10:25Z

Confirmed working. Anyone using Poetry for their dependencies can use:

[tool.poetry.dependencies]
typer = { git = "https://github.com/madkinsz/typer.git", rev = "b6efa2f" }

Andrew-Sheridan · 2022-03-30T01:28:43Z

@tiangolo any chance you could take a look at this?

Thank you

github-actions · 2022-03-30T16:47:54Z

📝 Docs preview for commit b6efa2f at: https://6244897abaa0e80081318186--typertiangolo.netlify.app

codecov · 2022-03-30T16:48:49Z

Codecov Report

Merging #375 (b6efa2f) into master (6d8e954) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          252       252           
  Lines         5287      5287           
=========================================
  Hits          5287      5287

Impacted Files	Coverage Δ
tests/__init__.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8e954...b6efa2f. Read the comment docs.

zanieb · 2022-03-30T18:33:24Z

Requires a black update to pass CI as it's affected by the same bug :)

Closing in favor of #380

tiangolo · 2022-03-30T19:23:15Z

Thanks for the work @madkinsz! And thanks everyone for the feedback. This was included in #380, and is now released in Typer 0.4.1. 🚀 🎉

jepler · 2022-03-30T21:48:06Z

Thank you @tiangolo

In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375

Fix import of get_terminal_size for click 8.1.0 support

b6efa2f

browniebroke mentioned this pull request Mar 28, 2022

ImportError: cannot import name 'get_terminal_size' from 'click.termui' #377

Closed

7 tasks

zanieb marked this pull request as ready for review March 28, 2022 19:15

bdraco mentioned this pull request Mar 28, 2022

Disable Unifi Protect Oldest Recording sensor by default home-assistant/core#68804

Merged

22 tasks

jepler mentioned this pull request Mar 28, 2022

Pin click typer adafruit/cascadetoml#8

Merged

epenet mentioned this pull request Mar 28, 2022

Pin click to fix typer issue home-assistant/core#68808

Merged

22 tasks

browniebroke mentioned this pull request Mar 28, 2022

Add support for Typer ewels/rich-click#26

Merged

hvy mentioned this pull request Mar 29, 2022

Avoid latest click==8.1.0 that removed a deprecated feature optuna/optuna#3413

Merged

paw-lu mentioned this pull request Mar 29, 2022

ImportError: cannot import name 'get_terminal_size' from 'click.termui' paw-lu/nbpreview#525

Closed

raxod502 mentioned this pull request Mar 29, 2022

[Bug]: Not compatible with Click 8.1.0 released 2022-03-28 pacstall/pacup.py#17

Closed

zanieb mentioned this pull request Mar 29, 2022

Import get_terminal_size from shutil #378

Closed

roll mentioned this pull request Mar 29, 2022

Upgrade Typer version because of the Click problem frictionlessdata/frictionless-py#1011

Closed

svlandeg mentioned this pull request Mar 29, 2022

New click library version (8.1.0) breaks spaCy explosion/spaCy#10564

Closed

petrchmelar mentioned this pull request Mar 29, 2022

get_terminal_size was removed in click 8.1.0 cruft/cruft#151

Closed

zanieb mentioned this pull request Mar 29, 2022

Prefect 2 not compatible with click 8.1.0 PrefectHQ/prefect#5609

Closed

bollwyvl mentioned this pull request Mar 30, 2022

click 8.1.0 breaks typer 0.4.0 conda-forge/typer-feedstock#7

Closed

5 tasks

egpbos mentioned this pull request Mar 30, 2022

Update CI dianna-ai/dianna#289

Merged

This was referenced Mar 30, 2022

click latest release as a dependency to typer causes error pallets/click#2230

Closed

ImportError: cannot import name 'get_terminal_size' from 'click.termui' pallets/click#2226

Closed

tiangolo mentioned this pull request Mar 30, 2022

🐛 Fix import of get_terminal_size for click 8.1.0 support and upgrade Black for CI #380

Merged

zanieb closed this Mar 30, 2022

r-b-g-b mentioned this pull request Apr 13, 2022

adding xgboost to dependencies drivendataorg/nasa-airport-config-runtime#6

Merged

Cielquan mentioned this pull request Aug 14, 2022

[Bug]: Click ImportError due to Typer dependency rstcheck/rstcheck#138

Closed

3 tasks

alice-cool mentioned this pull request Sep 9, 2022

生成的trainval_36.h5 中没有”cls_score“，无法运行python tools/preprocess-hint.py --exp qa BierOne/VQA-AttReg#1

Closed

PhreakHeaven mentioned this pull request Dec 14, 2022

ImportError: cannot import name 'get_terminal_size' from 'click.termui' adieyal/sd-dynamic-prompts#106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add click 8.1.0 support#375

Add click 8.1.0 support#375
zanieb wants to merge 1 commit intofastapi:masterfrom
zanieb:click-810

zanieb commented Mar 28, 2022 •

edited

Loading

Uh oh!

jepler commented Mar 28, 2022

Uh oh!

genos commented Mar 29, 2022

Uh oh!

Ravi4moreyeahs commented Mar 29, 2022

Uh oh!

danielbraun89 commented Mar 29, 2022

Uh oh!

jepler commented Mar 29, 2022

Uh oh!

austinbutler commented Mar 29, 2022

Uh oh!

Andrew-Sheridan commented Mar 30, 2022

Uh oh!

github-actions bot commented Mar 30, 2022

Uh oh!

codecov bot commented Mar 30, 2022

Uh oh!

zanieb commented Mar 30, 2022

Uh oh!

tiangolo commented Mar 30, 2022

Uh oh!

jepler commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

zanieb commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jepler commented Mar 28, 2022

Uh oh!

genos commented Mar 29, 2022

Uh oh!

Ravi4moreyeahs commented Mar 29, 2022

Uh oh!

danielbraun89 commented Mar 29, 2022

Uh oh!

jepler commented Mar 29, 2022

Uh oh!

austinbutler commented Mar 29, 2022

Uh oh!

Andrew-Sheridan commented Mar 30, 2022

Uh oh!

github-actions bot commented Mar 30, 2022

Uh oh!

codecov bot commented Mar 30, 2022

Codecov Report

Uh oh!

zanieb commented Mar 30, 2022

Uh oh!

tiangolo commented Mar 30, 2022

Uh oh!

jepler commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zanieb commented Mar 28, 2022 •

edited

Loading