Skip to content

Conversation

@YuriiMotov
Copy link
Member

@YuriiMotov YuriiMotov commented Dec 23, 2025

Note that target branch is drop-python3.8-support.


There is minor issue with some code examples in https://24ef2783.typertiangolo.pages.dev/tutorial/one-file-per-command/ labeled as Python 3.8+ - this is because of nested folders (variant info is encoded not in filder name, but in parent folder name). But code is valid for 3.8.


There were some code examples not covered by tests. I decided not to add tests in this PR (it's already huge), but added those files to omit section in coverage config. See pyproject.toml


Attention: I temporarily inluded commit from #1458 to fix failing CI

@YuriiMotov YuriiMotov added the docs Improvements or additions to documentation label Dec 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

📝 Docs preview

Last commit 64fa088 at: https://84e75b6d.typertiangolo.pages.dev

Modified Pages

@YuriiMotov YuriiMotov force-pushed the update-code-examples-to-python-3.9 branch from 464e643 to eb7a6aa Compare December 23, 2025 11:05
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you @YuriiMotov! 🙌 🎉 🔥

):
"""
**Create** a new *shinny* user. :sparkles:
**Create** a new *shiny* user. :sparkles:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! 🔍

@tiangolo tiangolo changed the title 📝 Update code examples to python 3.9 📝 Update code examples to Python 3.9 Dec 24, 2025
Base automatically changed from drop-python3.8-support to master December 24, 2025 23:23
@tiangolo tiangolo merged commit 51e48d2 into master Dec 25, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants