-
-
Notifications
You must be signed in to change notification settings - Fork 826
📝 Update code examples to Python 3.9 #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
464e643 to
eb7a6aa
Compare
tiangolo
approved these changes
Dec 24, 2025
Member
tiangolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you @YuriiMotov! 🙌 🎉 🔥
| ): | ||
| """ | ||
| **Create** a new *shinny* user. :sparkles: | ||
| **Create** a new *shiny* user. :sparkles: |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you! 🔍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that target branch is
drop-python3.8-support.There is minor issue with some code examples in https://24ef2783.typertiangolo.pages.dev/tutorial/one-file-per-command/ labeled as Python 3.8+ - this is because of nested folders (variant info is encoded not in filder name, but in parent folder name). But code is valid for 3.8.
There were some code examples not covered by tests. I decided not to add tests in this PR (it's already huge), but added those files to
omitsection in coverage config. See pyproject.tomlAttention: I temporarily inluded commit from #1458 to fix failing CI