Skip to content

💚 Move ruff dependency to shared requirements-docs-tests.txt to fix "Build docs" workflow in CI #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 1 commit into from
Dec 23, 2025
Merged

💚 Move ruff dependency to shared requirements-docs-tests.txt to fix "Build docs" workflow in CI #1458

tiangolo merged 1 commit into from
Dec 23, 2025

Conversation

@YuriiMotov
Copy link
Member

@YuriiMotov YuriiMotov commented Dec 23, 2025 •
edited
Loading

Currently scripts/docs.py requires ruff, but requirements-docs.txt doesn't include it, so Build docs workflow fails

python ./scripts/docs.py verify-readme
...
Traceback (most recent call last):
  File "/home/runner/work/typer/typer/./scripts/docs.py", line 9, in <module>
    from ruff.__main__ import find_ruff_bin
ModuleNotFoundError: No module named 'ruff'

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

📝 Docs preview

Last commit 5217ce8 at: https://ad15d109.typertiangolo.pages.dev

@YuriiMotov YuriiMotov mentioned this pull request Dec 23, 2025
Merged
tiangolo
tiangolo approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@tiangolo tiangolo merged commit c1806c4 into master Dec 23, 2025
30 checks passed
@tiangolo tiangolo deleted the move-ruff-dependency-to-requirements-docs-tests branch December 23, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiangolo tiangolo tiangolo approved these changes

Assignees

No one assigned

Labels

internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YuriiMotov @tiangolo