Skip to content

🌐 Add Korean translation for Tutorial - Extra Models #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peebbv6364 wants to merge 5 commits into from
Closed

🌐 Add Korean translation for Tutorial - Extra Models #3162

peebbv6364 wants to merge 5 commits into from

Conversation

@peebbv6364
Copy link

@peebbv6364 peebbv6364 commented May 3, 2021

Hello
I translated the Extra Models part of the tutorial.
Please review if there is anything wrong. thanks.

This PR translates tutorial/extra-models.md in Korean.
related: #2017

@peebbv6364
translate docs/ko/docs/tutorial/extra-models.md
a717c15 
(cherry picked from commit 2e0ff7f87cd71c4b6dc24a3fe3c269d9f3b76fd1)
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021 •
edited
Loading

Codecov Report

Merging #3162 (a717c15) into master (ce0ec06) will not change coverage.
The diff coverage is n/a.

❗ Current head a717c15 differs from pull request most recent head 346bfec. Consider uploading reports for the commit 346bfec to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2252837...346bfec. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

📝 Docs preview for commit a717c15 at: https://609108b97f4e92048dd9a39f--fastapi.netlify.app

hard-coders
hard-coders reviewed May 4, 2021
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard 🎉

It's a great job, and I really appreciate your work!
Please see the reviews and tell me what you think.

@peebbv6364
Copy link
Author

peebbv6364 commented May 4, 2021

@hard-coders
Thank you for your review.
I accepted your points and pushed the new commit.

hard-coders
hard-coders reviewed May 4, 2021
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing is left to do.

You must modify docs/ko/mkdocs.yml

peebbv6364 and others added 2 commits May 5, 2021 10:46
hard-coders
hard-coders approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems perfect. 🚀

@DevDae DevDae mentioned this pull request Oct 9, 2021
Closed
joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#3162
ab0cfe2
@peebbv6364 peebbv6364 closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hard-coders hard-coders hard-coders approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peebbv6364 @hard-coders @tiangolo