Skip to content

🌐 Add Dutch translation for docs/nl/docs/python-types.md#12158

Merged
alejsdev merged 16 commits intofastapi:masterfrom
maxscheijen:master
Sep 12, 2024
Merged

🌐 Add Dutch translation for docs/nl/docs/python-types.md#12158
alejsdev merged 16 commits intofastapi:masterfrom
maxscheijen:master

Conversation

@maxscheijen
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions bot added the lang-all Translations label Sep 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2024

@alejsdev alejsdev added awaiting-review lang-nl Dutch translations labels Sep 7, 2024
@svlandeg svlandeg self-requested a review September 9, 2024 08:11
Copy link
Copy Markdown
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxscheijen, thanks for another great translation PR!

I've verified that this translation is in sync with the latest English page on master and overall it looks really good. I left some small comments, mostly to ensure consistency with the other Dutch translations.

PS: I see that you've been making these edits from your master branch of your fork. For the next time, the recommended practice is to keep your fork's master branch synced with the upstream repo, and to create a new branch on your fork whenever you want to open a PR with new edits. This way, the old commits of previous work also won't show up here, and it's easier to track the branches with one branch always corresponding to one PR, etc.

maxscheijen and others added 2 commits September 9, 2024 14:38
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2024

@maxscheijen maxscheijen requested a review from svlandeg September 9, 2024 12:50
Copy link
Copy Markdown
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!

PS: I'm keeping track of some of the main decisions in #9200 (first post) to record some of the decisions we're taking and to ensure consistency across pages 😉

@maxscheijen
Copy link
Copy Markdown
Contributor Author

Looks good, thanks again!

PS: I'm keeping track of some of the main decisions in #9200 (first post) to record some of the decisions we're taking and to ensure consistency across pages 😉

That's great! Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2024

@alejsdev alejsdev merged commit c8e644d into fastapi:master Sep 12, 2024
@alejsdev
Copy link
Copy Markdown
Member

Nice, thank you! @maxscheijen @svlandeg 😸

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-nl Dutch translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants