♻️ Refactor deciding if embed body fields, do not overwrite fields, compute once per router, refactor internals in preparation for Pydantic models in Form, Query and others
#12117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includeamin
reviewed
Sep 2, 2024
…del_field()` to re-use it for params and body
…`Union[SomeSequence, None]`
…s, query parameters
embed body fields, do not overwrite fields, compute once per routerembed body fields, do not overwrite fields, compute once per router, refactor internals in preparation for Pydantic models in Form, Query and others
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
… compute once per router, refactor internals in preparation for Pydantic models in `Form`, `Query` and others (fastapi#12117)
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
… compute once per router, refactor internals in preparation for Pydantic models in `Form`, `Query` and others (fastapi#12117)
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
… compute once per router, refactor internals in preparation for Pydantic models in `Form`, `Query` and others (fastapi#12117)
s-rigaud
pushed a commit
to s-rigaud/fastapi
that referenced
this pull request
Jan 23, 2025
… compute once per router, refactor internals in preparation for Pydantic models in `Form`, `Query` and others (fastapi#12117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Refactor deciding if
embedbody fields, do not overwrite fields, compute once per router