Skip to content

🌐 Update Chinese translation for docs/zh/docs/tutorial/dependencies/dependencies-with-yield.md#12028

Merged
alejsdev merged 6 commits intofastapi:masterfrom
xuvjso:dependencies-with-yield-docs-fix
Aug 19, 2024
Merged

🌐 Update Chinese translation for docs/zh/docs/tutorial/dependencies/dependencies-with-yield.md#12028
alejsdev merged 6 commits intofastapi:masterfrom
xuvjso:dependencies-with-yield-docs-fix

Conversation

@xuvjso
Copy link
Copy Markdown
Contributor

@xuvjso xuvjso commented Aug 16, 2024

#10831 ensures that the code following yield executes after the response is create but before it is sent to the client. The statement in #3620 (comment) was outdated, it is now safe to commit the session after yield as the code is guaranteed to execute after the response is created but before it is sent.

def get_db() -> Session:
    session = SessionLocal()
    try:
        yield session
        session.commit()
    except:
        session.rollback()
        raise
    finally:
        session.close()

@github-actions github-actions bot added the docs Documentation about how to use FastAPI label Aug 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2024

📝 Docs preview for commit 3ee6126 at: https://4a9d8a2a.fastapitiangolo.pages.dev

Modified Pages

@estebanx64 estebanx64 added lang-zh Chinese translations awaiting-review labels Aug 16, 2024
@estebanx64 estebanx64 changed the title Update docs about dependencies with yield 🌐 Update docs about dependencies with yield Aug 16, 2024
@estebanx64
Copy link
Copy Markdown
Contributor

estebanx64 commented Aug 16, 2024

Thanks for your time and interest in helping us! 🙇

We are going to review these little changes 🤓

@estebanx64 estebanx64 added lang-all Translations and removed docs Documentation about how to use FastAPI labels Aug 16, 2024
@github-actions github-actions bot added the docs Documentation about how to use FastAPI label Aug 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2024

📝 Docs preview for commit 23c975a at: https://4ec69d0d.fastapitiangolo.pages.dev

Modified Pages

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 17, 2024

📝 Docs preview for commit ddb5473 at: https://2f94f191.fastapitiangolo.pages.dev

Modified Pages

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 17, 2024

📝 Docs preview for commit a1ae1b3 at: https://7132c1e4.fastapitiangolo.pages.dev

Modified Pages

@xuvjso
Copy link
Copy Markdown
Contributor Author

xuvjso commented Aug 17, 2024

I noticed that the chinese version of the "dependencies with yield" section of the documentation is outdated, so I provided an updated translation to prevent users from being misled by outdated information and to align with the latest English documentation.

@alejsdev alejsdev removed the docs Documentation about how to use FastAPI label Aug 19, 2024
@alejsdev
Copy link
Copy Markdown
Member

alejsdev commented Aug 19, 2024

Hi @xuvjso
Thanks for your interest in contributing to FastAPI 🙇‍♀️
To avoid problems with the labels. Could you better separate the EN from the ZH docs in another PR? Thanks in advance! 🙏

@github-actions github-actions bot added the docs Documentation about how to use FastAPI label Aug 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2024

📝 Docs preview for commit 182017a at: https://d843aa0a.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev removed the docs Documentation about how to use FastAPI label Aug 19, 2024
@alejsdev alejsdev merged commit f0866bc into fastapi:master Aug 19, 2024
@alejsdev
Copy link
Copy Markdown
Member

alejsdev commented Aug 19, 2024 •
edited
Loading

Great! Thanks for your contribution 🥳 @xuvjso
And thanks for the review 💯 @Aruelius

@alejsdev alejsdev changed the title 🌐 Update docs about dependencies with yield 🌐 Update Chinese translation for docs/zh/docs/tutorial/dependencies/dependencies-with-yield.md Aug 19, 2024
@xuvjso
Copy link
Copy Markdown
Contributor Author

xuvjso commented Aug 19, 2024

Great! Thanks for your contribution 🥳 @xuvjso And thanks for the review 💯 @Aruelius

It's my pleasure. 😊

@xuvjso xuvjso deleted the dependencies-with-yield-docs-fix branch August 19, 2024 17:50
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@xuvjso @black-redoc
🌐 Update docs about dependencies with yield (fastapi#12028)
5a0e403
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@xuvjso @black-redoc
🌐 Update docs about dependencies with yield (fastapi#12028)
abb09fe
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@xuvjso @black-redoc
🌐 Update docs about dependencies with yield (fastapi#12028)
90d36bf
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@xuvjso @s-rigaud
🌐 Update docs about dependencies with yield (fastapi#12028)
e37f60a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Aruelius Aruelius Aruelius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-1 lang-all Translations lang-zh Chinese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xuvjso @estebanx64 @alejsdev @Aruelius