📝 Several docs improvements, tweaks, and clarifications#11390
📝 Several docs improvements, tweaks, and clarifications#11390tiangolo merged 6 commits intofastapi:masterfrom
Conversation
|
Hi @nilslindemann, thanks for the PR! Especially appreciate you breaking out more ambiguous changes into its separate PR & commit - these kind of considerations certainly help us push "less ambiguous" fixes through more easily 🙏 I'll get this PR updated with the latest of |
svlandeg
left a comment
There was a problem hiding this comment.
These edits mostly look good to me. Rewriting words like "it" to more clear references helps with readability for new users as well, so I'm all for it.
Also really appreciate you checking all links and rewriting them to better suited links where relevant 🙏
|
Awesome, thanks a lot for this @nilslindemann! 🚀 You rock! 🎸 And thanks a lot @svlandeg for the thorough review! 🙇 I tweaked a couple of places and included Sofie's suggestions, this is now ready. Thank you! 🍰 |
Co-authored-by: svlandeg <svlandeg@github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Co-authored-by: svlandeg <svlandeg@github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
|
Thanks people, especially @svlandeg! I know this was quite some work. Well done! |
Co-authored-by: svlandeg <svlandeg@github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
These are more ambiguous changes subtracted from #11389. Smaller PR, but look more closely. The first two commits are improvements in my opinion. I am unsure about the third commit.