-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
📌 Pin Swagger UI version to 5.9.0 temporarily to handle a bug crashing it in 5.9.1 #10529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 5.9.1 released on 25/10/2023 has a bug related to recursive schema definitions Issue reported at: swagger-api/swagger-ui#9337
Member
|
📝 Docs preview for commit 26fa5ca at: https://d6e884fe.fastapitiangolo.pages.dev |
Member
|
Great, thank you @alejandraklachquin! 🚀 🎉 This will be available in |
|
FYI. See also this monkey patch approach from a prior incident. |
Contributor
Author
|
@chipytux thanks for the encouragement ❤️ |
|
@tiangolo This PR can be reverted because swagger ui released a new version with fix. |
gisbdzhch
pushed a commit
to gisktzh/gb3-search_api
that referenced
this pull request
Dec 6, 2023
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastapi](https://github.com/tiangolo/fastapi) | `==0.92.0` -> `==0.104.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tiangolo/fastapi (fastapi)</summary> ### [`v0.104.1`](https://github.com/tiangolo/fastapi/releases/tag/0.104.1) [Compare Source](fastapi/fastapi@0.104.0...0.104.1) ##### Fixes - 📌 Pin Swagger UI version to 5.9.0 temporarily to handle a bug crashing it in 5.9.1. PR [#​10529](fastapi/fastapi#10529) by [@​alejandraklachquin](https://github.com/alejandraklachquin). - This is not really a bug in FastAPI but in Swagger UI, nevertheless pinning the version will work while a solution is found on the [Swagger UI side](swagger-api/swagger-ui#9337). ##### Docs - 📝 Update data structure and render for external-links. PR [#​10495](fastapi/fastapi#10495) by [@​tiangolo](https://github.com/tiangolo). - ✏️ Fix link to SPDX license identifier in `docs/en/docs/tutorial/metadata.md`. PR [#​10433](fastapi/fastapi#10433) by [@​worldworm](https://github.com/worldworm). - 📝 Update example validation error from Pydantic v1 to match Pydantic v2 in `docs/en/docs/tutorial/path-params.md`. PR [#​10043](fastapi/fastapi#10043) by [@​giuliowaitforitdavide](https://github.com/giuliowaitforitdavide). - ✏️ Fix typos in emoji docs and in some source examples. PR [#​10438](fastapi/fastapi#10438) by [@​afuetterer](https://github.com/afuetterer). - ✏️ Fix typo in `docs/en/docs/reference/dependencies.md`. PR [#​10465](fastapi/fastapi#10465) by [@​suravshresth](https://github.com/suravshresth). - ✏️ Fix typos and rewordings in `docs/en/docs/tutorial/body-nested-models.md`. PR [#​10468](fastapi/fastapi#10468) by [@​yogabonito](https://github.com/yogabonito). - 📝 Update docs, remove references to removed `pydantic.Required` in `docs/en/docs/tutorial/query-params-str-validations.md`. PR [#​10469](fastapi/fastapi#10469) by [@​yogabonito](https://github.com/yogabonito). - ✏️ Fix typo in ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swagger-ui version 5.9.1 released on 25/10/2023 (a day ago) has a bug related to recursive schema definitions
Issue reported at:
Discussion at fastAPI: