Skip to content

Conversation

@alejandraklachquin
Copy link
Contributor

@alejandraklachquin alejandraklachquin commented Oct 26, 2023

swagger-ui version 5.9.1 released on 25/10/2023 (a day ago) has a bug related to recursive schema definitions
Issue reported at:

Discussion at fastAPI:

alejandraklachquin and others added 2 commits October 26, 2023 18:02
version 5.9.1 released on 25/10/2023 has a bug related to recursive schema definitions
Issue reported at: swagger-api/swagger-ui#9337
@tiangolo
Copy link
Member

📝 Docs preview for commit 26fa5ca at: https://d6e884fe.fastapitiangolo.pages.dev

@tiangolo tiangolo changed the title fix: freeze swagger-ui version to 5.9.0 📌 Pin Swagger UI version to 5.9.0 temporarily to handle https://github.com/swagger-api/swagger-ui/issues/9337 Oct 30, 2023
@tiangolo tiangolo changed the title 📌 Pin Swagger UI version to 5.9.0 temporarily to handle https://github.com/swagger-api/swagger-ui/issues/9337 📌 Pin Swagger UI version to 5.9.0 temporarily to handle a bug crashing it in 5.9.1 Oct 30, 2023
@tiangolo
Copy link
Member

Great, thank you @alejandraklachquin! 🚀 🎉

This will be available in 0.104.1 in the next hours. 🎉

@tiangolo tiangolo merged commit 758a8f2 into fastapi:master Oct 30, 2023
@hellobrett
Copy link

FYI. See also this monkey patch approach from a prior incident.

#1762 (comment)

@alejandraklachquin
Copy link
Contributor Author

@chipytux thanks for the encouragement ❤️

@elonzh
Copy link

elonzh commented Nov 10, 2023

@tiangolo This PR can be reverted because swagger ui released a new version with fix.

gisbdzhch pushed a commit to gisktzh/gb3-search_api that referenced this pull request Dec 6, 2023
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastapi](https://github.com/tiangolo/fastapi) | `==0.92.0` -> `==0.104.1` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/fastapi/0.104.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/fastapi/0.104.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/fastapi/0.92.0/0.104.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/fastapi/0.92.0/0.104.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>tiangolo/fastapi (fastapi)</summary>

### [`v0.104.1`](https://github.com/tiangolo/fastapi/releases/tag/0.104.1)

[Compare Source](fastapi/fastapi@0.104.0...0.104.1)

##### Fixes

-   📌 Pin Swagger UI version to 5.9.0 temporarily to handle a bug crashing it in 5.9.1. PR [#&#8203;10529](fastapi/fastapi#10529) by [@&#8203;alejandraklachquin](https://github.com/alejandraklachquin).
    -   This is not really a bug in FastAPI but in Swagger UI, nevertheless pinning the version will work while a solution is found on the [Swagger UI side](swagger-api/swagger-ui#9337).

##### Docs

-   📝 Update data structure and render for external-links. PR [#&#8203;10495](fastapi/fastapi#10495) by [@&#8203;tiangolo](https://github.com/tiangolo).
-   ✏️ Fix link to SPDX license identifier in `docs/en/docs/tutorial/metadata.md`. PR [#&#8203;10433](fastapi/fastapi#10433) by [@&#8203;worldworm](https://github.com/worldworm).
-   📝 Update example validation error from Pydantic v1 to match Pydantic v2 in `docs/en/docs/tutorial/path-params.md`. PR [#&#8203;10043](fastapi/fastapi#10043) by [@&#8203;giuliowaitforitdavide](https://github.com/giuliowaitforitdavide).
-   ✏️ Fix typos in emoji docs and in some source examples. PR [#&#8203;10438](fastapi/fastapi#10438) by [@&#8203;afuetterer](https://github.com/afuetterer).
-   ✏️ Fix typo in `docs/en/docs/reference/dependencies.md`. PR [#&#8203;10465](fastapi/fastapi#10465) by [@&#8203;suravshresth](https://github.com/suravshresth).
-   ✏️ Fix typos and rewordings in `docs/en/docs/tutorial/body-nested-models.md`. PR [#&#8203;10468](fastapi/fastapi#10468) by [@&#8203;yogabonito](https://github.com/yogabonito).
-   📝 Update docs, remove references to removed `pydantic.Required` in `docs/en/docs/tutorial/query-params-str-validations.md`. PR [#&#8203;10469](fastapi/fastapi#10469) by [@&#8203;yogabonito](https://github.com/yogabonito).
-   ✏️ Fix typo in ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants