Merge the Docments Sprint!#3639
Merged
Merged
Conversation
Add docment for TfmdLists
docment GAN
Merge upstream updates
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging of the fastai docments sprint
What does this add?
This PR adds docments to an extremely large chunk of the library, and would not be possible without the help of over 20 community members.
It also updates the fastai notebooks to use the new nbdev annotations for tags
from future import __annotations__was added to the top of every exported notebook as well in the first export cell.Current issues
There are 114 cases where a tuple annotation is used for types such as:
myVar:(type1, type2)and it needs to be replaced with a pipe,myVar:type1|type2. Until then, VSCode will complain (specifically PyLance)@jph00 what ever you do, do not hit squash and merge so everyone else's commits stay in!