Add docment for TfmdLists#96
Merged
warner-benjamin merged 6 commits intoMar 13, 2022
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kevinbird15
requested changes
Mar 5, 2022
kevinbird15
left a comment
Collaborator
There was a problem hiding this comment.
This piece is definitely dense so looking for another reviewer to back me up on some of my changes as well
warner-benjamin
requested changes
Mar 11, 2022
warner-benjamin
left a comment
Collaborator
There was a problem hiding this comment.
Please replicate suggestions to the notebook and TfmdLists method. For most arg strings I think we can remove "List of" as the type hint indicates it's a list.
7b4b0a4 to
d355494
Compare
Co-authored-by: Kevin Bird <kevinbird15@gmail.com>
Co-authored-by: Benjamin Warner <me@benjaminwarner.dev>
d355494 to
b8c67fb
Compare
warner-benjamin
approved these changes
Mar 13, 2022
warner-benjamin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The build errors should be fixed now that the main branch uses nbdev git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
TfmdListstask in issue #8