fix(scap_engine_bpf): enable _64BIT_ARGS_SINGLE_REGISTER on ARM64#418
Merged
poiana merged 1 commit intofalcosecurity:masterfrom Jun 24, 2022
Merged
fix(scap_engine_bpf): enable _64BIT_ARGS_SINGLE_REGISTER on ARM64#418poiana merged 1 commit intofalcosecurity:masterfrom
_64BIT_ARGS_SINGLE_REGISTER on ARM64#418poiana merged 1 commit intofalcosecurity:masterfrom
Conversation
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Contributor
|
LGTM label has been added. DetailsGit tree hash: d497cd9e29995e9c47f52cb258879a9008c2005e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
15 tasks
leogr
pushed a commit
to leogr/libs
that referenced
this pull request
Jan 5, 2023
…falcosecurity#93) - Falcosecurity/libs falcosecurity#416: Support execve exit and clone child exit events on ARM64 - Falcosecurity/libs falcosecurity#418: Enable 64BIT_ARGS_SINGLE_REGISER on ARM64 - Also, disable userspace workarounds ARM, which attempted to compensate for the missing execve/clone exit events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-bpf
/area libscap-engine-bpf
What this PR does / why we need it:
If we are on a
64-bitarchitecture we need to enable the_64BIT_ARGS_SINGLE_REGISTERmacro and this is done correctly in our drivers. The problem is that when we compilescapwe enable this define only inx86So on ARM64, when we fill the filler table in the libscap bpf engine we use the wrong fillers for some syscalls:
For
PPME_SYSCALL_PREAD_Eevent we use thesys_pread64_efiller instead ofsys_autofilland this cause an event drop since we define thesys_pread64_ein this way:Causing a
scap-openoutput similar to this:Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: