Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: faker-ruby/faker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.3.0
Choose a base ref
...
head repository: faker-ruby/faker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.3.1
Choose a head ref
  • 6 commits
  • 87 files changed
  • 4 contributors

Commits on Mar 26, 2024

  1. Bump rubocop-minitest from 0.34.4 to 0.35.0 (#2918)

    * Bump rubocop-minitest from 0.34.4 to 0.35.0
    
    Bumps [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) from 0.34.4 to 0.35.0.
    - [Release notes](https://github.com/rubocop/rubocop-minitest/releases)
    - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md)
    - [Commits](rubocop/rubocop-minitest@v0.34.4...v0.35.0)
    
    ---
    updated-dependencies:
    - dependency-name: rubocop-minitest
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    * Run rubocop's autocorrectable command
    
    ---------
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Stefanni Brasil <stefannibrasil@gmail.com>
    dependabot[bot] and sbs-cats authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5b27fe4 View commit details
    Browse the repository at this point in the history
  2. Added docs for Deprecator in CONTRIBUTING.md (#2919)

    * Added docs for deprecator in CONTRIBUTING.md
    
    * Updated CONTRIBUTING.md with test instructions for deprecated Generators
    keshavbiswa authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3c85321 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Move en-US.yml's cell_phone entry to the correct position (#2924)

    `PhoneNumber.cell_phone` expects an i18n key of `cell_phone.formats`,
    but the en-US.yml file currently has `faker.phone_number.cell_phone`
    instead of `faker.cell_phone`.
    
    The result of that mismatch is that `cell_phone` will ignore the defined
    formats, and potentially generate invalid US numbers (e.g. those with an
    area code beginning with 1) when the locale is en-US.
    
    31d99d1 reworked YAML structure and
    appears to have inadvertently moved the key.
    
    You can see the change in US number behavior in a console:
    
      Faker::Config.locale = "en-US"
      Faker::PhoneNumber.translate("faker.cell_phone.formats")
    
    On 3.3.0 this returns
    
      ["###-###-####", "(###) ###-####", "###.###.####", "### ### ####"]
    
    because it's the fallback value within the `en` (not `en-US`) locale
    file. The correct value should be the formats outdented in this commit.
    aprescott authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e15e606 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Rename Faker::show to Faker::Theater (#2921)

    * Renamed Faker::Show to Faker::Theater
    
    * Updated Readme
    
    * Updated test to explcitly use Faker::Theater
    keshavbiswa authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    dd8c88c View commit details
    Browse the repository at this point in the history
  2. renamed nhs to national_health_service (#2923)

    * renamed nhs to national_health_service
    
    * Reverted Gemfile.lock
    keshavbiswa authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    52e5d43 View commit details
    Browse the repository at this point in the history
  3. New patch release (#2925)

    sbs-cats authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    49fa02c View commit details
    Browse the repository at this point in the history
Loading