-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Comparing changes
Open a pull request
base repository: faker-ruby/faker
base: a21875f
head repository: faker-ruby/faker
compare: 49fa02c
- 6 commits
- 87 files changed
- 4 contributors
Commits on Mar 26, 2024
-
Bump rubocop-minitest from 0.34.4 to 0.35.0 (#2918)
* Bump rubocop-minitest from 0.34.4 to 0.35.0 Bumps [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) from 0.34.4 to 0.35.0. - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-minitest@v0.34.4...v0.35.0) --- updated-dependencies: - dependency-name: rubocop-minitest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Run rubocop's autocorrectable command --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefanni Brasil <stefannibrasil@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5b27fe4 - Browse repository at this point
Copy the full SHA 5b27fe4View commit details -
Added docs for Deprecator in CONTRIBUTING.md (#2919)
* Added docs for deprecator in CONTRIBUTING.md * Updated CONTRIBUTING.md with test instructions for deprecated Generators
Configuration menu - View commit details
-
Copy full SHA for 3c85321 - Browse repository at this point
Copy the full SHA 3c85321View commit details
Commits on Mar 28, 2024
-
Move en-US.yml's cell_phone entry to the correct position (#2924)
`PhoneNumber.cell_phone` expects an i18n key of `cell_phone.formats`, but the en-US.yml file currently has `faker.phone_number.cell_phone` instead of `faker.cell_phone`. The result of that mismatch is that `cell_phone` will ignore the defined formats, and potentially generate invalid US numbers (e.g. those with an area code beginning with 1) when the locale is en-US. 31d99d1 reworked YAML structure and appears to have inadvertently moved the key. You can see the change in US number behavior in a console: Faker::Config.locale = "en-US" Faker::PhoneNumber.translate("faker.cell_phone.formats") On 3.3.0 this returns ["###-###-####", "(###) ###-####", "###.###.####", "### ### ####"] because it's the fallback value within the `en` (not `en-US`) locale file. The correct value should be the formats outdented in this commit.
Configuration menu - View commit details
-
Copy full SHA for e15e606 - Browse repository at this point
Copy the full SHA e15e606View commit details
Commits on Apr 2, 2024
-
Rename Faker::show to Faker::Theater (#2921)
* Renamed Faker::Show to Faker::Theater * Updated Readme * Updated test to explcitly use Faker::Theater
Configuration menu - View commit details
-
Copy full SHA for dd8c88c - Browse repository at this point
Copy the full SHA dd8c88cView commit details -
renamed nhs to national_health_service (#2923)
* renamed nhs to national_health_service * Reverted Gemfile.lock
Configuration menu - View commit details
-
Copy full SHA for 52e5d43 - Browse repository at this point
Copy the full SHA 52e5d43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49fa02c - Browse repository at this point
Copy the full SHA 49fa02cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff a21875f...49fa02c