Update sphere.py -- add pooling and max_pooling#1596
Merged
teytaud merged 17 commits intofacebookresearch:mainfrom Feb 20, 2024
Merged
Update sphere.py -- add pooling and max_pooling#1596teytaud merged 17 commits intofacebookresearch:mainfrom
teytaud merged 17 commits intofacebookresearch:mainfrom
Conversation
teytaud
reviewed
Feb 17, 2024
Contributor
teytaud
left a comment
There was a problem hiding this comment.
Please use the same signature as other codes so that it can work in the quasi-randomize function.
Please add your code as default in quasi-randomize, when len(shape) > 1, instead of dispersion_with_big_conv.
nevergrad/common/sphere.py
Outdated
| "Riesz_blursum_lowconv_midorder", | ||
| "Riesz_blursum_lowconv_highorder", | ||
| "max_pooling", | ||
| "pooling" |
Contributor
There was a problem hiding this comment.
All methods in the list have the same signature, so that they can be used by quasi-randomize.
Please use the same signature.
fix signature of pooling and max_pooling
fix style
Contributor
|
Does it run ? This does not work as Torch is not in the dependencies. Also you need black. |
remove torch dependency
black formatting
- black - change standard avg pooling size
fix black
teytaud
pushed a commit
that referenced
this pull request
Feb 16, 2025
* Update sphere.py * Update sphere.py fix signature of pooling and max_pooling * Update sphere.py fix style * Update sphere.py remove torch dependency * Update sphere.py * Update sphere.py * Update sphere.py black formatting * Update sphere.py * Update sphere.py - black - change standard avg pooling size * Update sphere.py * Update sphere.py * Update sphere.py fix black * Update sphere.py * Update sphere.py * Update sphere.py * Update sphere.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist