Skip to content

Docs / optimization : Rephrasing + fix broken code blocks#1493

Merged
teytaud merged 2 commits intofacebookresearch:mainfrom
LouisJustinTALLOT:patch-2
Sep 25, 2024
Merged

Docs / optimization : Rephrasing + fix broken code blocks#1493
teytaud merged 2 commits intofacebookresearch:mainfrom
LouisJustinTALLOT:patch-2

Conversation

@LouisJustinTALLOT
Copy link
Copy Markdown
Contributor

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Small changes to make the optimization page of the docs more readable.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 3, 2023
@teytaud
Copy link
Copy Markdown
Contributor

teytaud commented Feb 15, 2023

Hello! For the dangerous default value I guess it will be fixed just by a rebase (git rebase).
This might even solve the other bug.
Can you give it a try ?
Have a great day!

@teytaud
Copy link
Copy Markdown
Contributor

teytaud commented Nov 21, 2023

Hello @LouisJustinTALLOT ; maybe just rebase and everything will be fine in the CI ?

@teytaud teytaud merged commit 72c7e01 into facebookresearch:main Sep 25, 2024
teytaud added a commit that referenced this pull request Feb 16, 2025
Co-authored-by: Teytaud <olivier.teytaud@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants