cherry pick DDA lazy init#31
Closed
kingchc wants to merge 2 commits intogenai-2.18.3from
Closed
Conversation
added 2 commits
October 7, 2023 21:56
Summary: Use `commHash`, instead of commId, as the UID for DDA. Unlike commId, commHash will be stored in `ncclComm_t` and it is derived from commId at init time. Use this as key can give us flexibility to lazily allocate DDA resource on-demand. Reviewed By: cenzhaometa Differential Revision: D49962123 fbshipit-source-id: c52369aa674fdbe02c2e8c46807d8e32c3e4a6a1
Summary: Postpone DDA allocation to later to reduce resource consumption at init time, and only be allocating resource when used Reviewed By: cenzhaometa Differential Revision: D49962764 fbshipit-source-id: 371834903f2d0fddbd80f6ba9c3e6bbe0b0d0d81
|
@kingchc has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Summary: Pull Request resolved: #31 Reviewed By: cenzhaometa Differential Revision: D50063012 Pulled By: kingchc fbshipit-source-id: 9b64bee4639f3fd58764b953cd6d8f8274565af6
minsii
pushed a commit
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: #31 Reviewed By: cenzhaometa Differential Revision: D50063012 Pulled By: kingchc fbshipit-source-id: 9b64bee4639f3fd58764b953cd6d8f8274565af6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.