[fix] Assign config to instance in setup as well#928
Closed
apsdehal wants to merge 1 commit intofacebookresearch:masterfrom
Closed
[fix] Assign config to instance in setup as well#928apsdehal wants to merge 1 commit intofacebookresearch:masterfrom
apsdehal wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
Summary: Followup to facebookresearch#921 for datasets which don't inherit from MMFDatasetBuilder Reviewed By: ytsheng Differential Revision: D28238562 fbshipit-source-id: 4fd609396138893da2cad30ed3cd1d6c5ce847f2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28238562 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Followup to #921 for datasets which don't inherit from MMFDatasetBuilder
Reviewed By: ytsheng
Differential Revision: D28238562