[feat] Add a memory usage regression test to the OSS benchmark#62
Merged
blefaudeux merged 10 commits intomasterfrom Sep 3, 2020
Merged
[feat] Add a memory usage regression test to the OSS benchmark#62blefaudeux merged 10 commits intomasterfrom
blefaudeux merged 10 commits intomasterfrom
Conversation
blefaudeux
commented
Sep 3, 2020
| assert (mean - 3.0 * std) < reference_speed, "Regression detected" | ||
| print(f"[Regression Test] Mean speed: {mean:.2f} +/- {std:.2f}") | ||
| assert (mean - 3.0 * std) < reference_speed, "Speed regression detected" | ||
| assert max_memory < 1.05 * reference_memory, "Memory use regression detected" |
Contributor
Author
There was a problem hiding this comment.
I added a 5% tolerance here, guessing that some CUDA or torch version changes could affect (I don't have any STD for this value, it's the max memory used over the whole run)
…ing in case two of them are run in a row
msbaines
approved these changes
Sep 3, 2020
myleott
pushed a commit
that referenced
this pull request
Feb 22, 2021
* Do reduce-scatter in a separate CUDA stream * Add _post_backward_stream to stubs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
definitely 🙃