Skip to content

[fix] optim/oss: work correctly with LRScheduler#58

Merged
msbaines merged 3 commits intomasterfrom
sync-lr
Aug 28, 2020
Merged

[fix] optim/oss: work correctly with LRScheduler#58
msbaines merged 3 commits intomasterfrom
sync-lr

Conversation

@msbaines
Copy link
Copy Markdown
Contributor

Sync lr before every step and before consolidate.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Sync lr before every step and before consolidate.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2020
Copy link
Copy Markdown
Contributor

@min-xu-ai min-xu-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msbaines msbaines merged commit ab32cb7 into master Aug 28, 2020
@msbaines msbaines deleted the sync-lr branch August 28, 2020 21:12
myleott pushed a commit that referenced this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants