Skip to content

[fix] refactor tests and fix state_dict#45

Merged
andersonic merged 2 commits intomasterfrom
refactor-adam-tests
Aug 19, 2020
Merged

[fix] refactor tests and fix state_dict#45
andersonic merged 2 commits intomasterfrom
refactor-adam-tests

Conversation

@andersonic
Copy link
Copy Markdown
Contributor

@andersonic andersonic commented Aug 19, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes state_dict and refactors tests further

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2020 •
edited
Loading

Codecov Report

Merging #45 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   94.20%   94.18%   -0.02%     
==========================================
  Files          35       35              
  Lines        2071     2065       -6     
==========================================
- Hits         1951     1945       -6     
  Misses        120      120
Flag Coverage Δ
#Python 94.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fairscale/optim/adam.py 93.04% <100.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee5a8f...42b4dc2. Read the comment docs.

@andersonic
Copy link
Copy Markdown
Contributor Author

andersonic commented Aug 19, 2020

8/19/2020 2:25PM NOT READY FOR REVIEW

@andersonic
Copy link
Copy Markdown
Contributor Author

andersonic commented Aug 19, 2020

8/19/2020 3:08PM READY

sidgoyal78
sidgoyal78 approved these changes Aug 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor. Looks good to me.

@andersonic andersonic merged commit 9d6c7b6 into master Aug 19, 2020
@andersonic andersonic deleted the refactor-adam-tests branch August 19, 2020 22:22
myleott pushed a commit that referenced this pull request Feb 22, 2021
Fix streams test (#45)
8db0cf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msbaines msbaines Awaiting requested review from msbaines

@shruti-bh shruti-bh Awaiting requested review from shruti-bh

1 more reviewer

@sidgoyal78 sidgoyal78 sidgoyal78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andersonic @sidgoyal78 @facebook-github-bot