feat: Add config option to toggle expr deduplication for non-deterministic functions#15008
Closed
kKPulla wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat: Add config option to toggle expr deduplication for non-deterministic functions#15008kKPulla wants to merge 1 commit intofacebookincubator:mainfrom
kKPulla wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
Contributor
2821100 to
212de4b
Compare
bikramSingh91
approved these changes
Oct 2, 2025
…istic functions (facebookincubator#15008) Summary: By default, we currently deduplicate non-deterministic functions during expression compilation. Having this option to toggle this behavior will let us make any plan deterministic that originally contains non-deterministic functions. Note: This is primarily intended for testing and debugging purposes and added a note to say the same in the description of the config. Reviewed By: bikramSingh91 Differential Revision: D83581786
212de4b to
775685f
Compare
Contributor
|
This pull request has been merged in ecb2baa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
By default, we currently deduplicate non-deterministic functions during expression compilation. Having this option to toggle this behavior will let us make any plan deterministic that originally contains non-deterministic functions.
Note: This is primarily intended for testing and debugging purposes and added a note to say the same in the description of the config.
Differential Revision: D83581786