misc: build Infima website deploy preview with RTL support#84
Merged
misc: build Infima website deploy preview with RTL support#84
Conversation
|
Size Change: 0 B Total Size: 527 kB ℹ️ View Unchanged
|
|
Deploy preview for infima ready! Built with commit 2660432 |
yangshun
approved these changes
Feb 19, 2021
Collaborator
Author
|
The current LTR support is broken in Netlify due to a little bug in Docusaurus: facebook/docusaurus#4254 It only works if the Infima git repo is fetched as https://deploy-preview-84--infima.netlify.app/rtl/
To get this working on Netlify, we need to:
|
# Conflicts: # yarn.lock
Collaborator
Author
|
fixed :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that Infima changes don't break RTL support in a docusaurus site (or at least provide a way to check manually)