fix(v2): fix LTR PostCSS bug on Netlify and monorepo symlinks#4254
Merged
fix(v2): fix LTR PostCSS bug on Netlify and monorepo symlinks#4254
Conversation
|
[V1] Deploy preview success Built with commit e1d0eb5 |
|
Deploy preview for docusaurus-2 ready! Built with commit e1d0eb5 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4254--docusaurus-2.netlify.app/classic/ |
|
Size Change: 0 B Total Size: 555 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
infima/packages/core/dist/css/default/default-rtl.cssis not a "reliable" path to check for the Infima CSS bundle.On Infima repo, it broke because Netlify fetches the Infima repo as
repo(ie notinfima) and the CSS file is at/opt/build/repo/packages/core/dist/css/default/default-rtl.cssThis broke the RTL support on Infima website deploy preview: facebookincubator/infima#84
The current method will be more reliable, as we are now comparing strictly 2 absolute file paths.