This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Add show + hide functionality#86
Closed
ScottCooper92 wants to merge 2 commits intofacebookarchive:masterfrom
ScottCooper92:hide_show
Closed
Add show + hide functionality#86ScottCooper92 wants to merge 2 commits intofacebookarchive:masterfrom ScottCooper92:hide_show
ScottCooper92 wants to merge 2 commits intofacebookarchive:masterfrom
ScottCooper92:hide_show
Conversation
xiphirx
suggested changes
Jun 27, 2019
| } | ||
|
|
||
| /** Return whether the shimmer is visible **/ | ||
| public boolean isShimmerVisible(){ |
Contributor
There was a problem hiding this comment.
I don't think is necessary to achieve the functionality desired. See below comments.
| * Sets the ShimmerDrawable to be visible. | ||
| * @param startShimmer Whether to start the shimmer again. | ||
| */ | ||
| public void showShimmer(boolean startShimmer) { |
Contributor
There was a problem hiding this comment.
Show / hide should be pretty simple and self sufficient within this class.
If we call showShimmer then it should simply set a boolean and start the shimmer if needed:
public void showShimmer() {
if (mShowShimmer) {
return;
}
mShowShimmer = true;
if (startShimmer) {
startShimmer();
}
}
Contributor
There was a problem hiding this comment.
Then in dispatchDraw we can just check to see if we want to show it.
if (mShowShimmer) {
mShimmerDrawable.draw(canvas);
}
| public class ShimmerFrameLayout extends FrameLayout { | ||
| private final Paint mContentPaint = new Paint(); | ||
| private final ShimmerDrawable mShimmerDrawable = new ShimmerDrawable(); | ||
| private Shimmer mShimmer = new Shimmer.AlphaHighlightBuilder().build(); |
Contributor
There was a problem hiding this comment.
Instead of this we should just have a simple boolean that denotes whether we should show the shimmer or not.
| /** Sets the ShimmerDrawable to be invisible, stopping it in the process. */ | ||
| public void hideShimmer() { | ||
| stopShimmer(); | ||
| updateShimmerDrawable(null); |
Contributor
There was a problem hiding this comment.
This should just set the boolean to false
Contributor
Author
|
I knew there would be an easier way to do it, I don't have a great deal of experience with custom drawables though. Show + hide now stop and start the ShimmerDrawable respectively and boolean gate the call to |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@xiphirx is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PoppyProses
added a commit
to PoppyProses/PoppyProses
that referenced
this pull request
Aug 20, 2025
Summary: PR for facebookarchive/shimmer-android#85 It doesn't seem like the best implementation since I'm just nulling the Shimmer but it does the job. I've tested this in the sample app by depending on the library project rather than the snapshot and added another button for toggling it on and off but haven't included any of that in this PR. If you would like me to I'll update it. Pull Request resolved: facebookarchive/shimmer-android#86 Differential Revision: D16053297 Pulled By: xiphirx fbshipit-source-id: 9f50e1f56c1f2272fbb2da70dbea3680da6e03f1
FelixiReed
added a commit
to FelixiReed/monoap
that referenced
this pull request
Sep 17, 2025
Summary: PR for facebookarchive/shimmer-android#85 It doesn't seem like the best implementation since I'm just nulling the Shimmer but it does the job. I've tested this in the sample app by depending on the library project rather than the snapshot and added another button for toggling it on and off but haven't included any of that in this PR. If you would like me to I'll update it. Pull Request resolved: facebookarchive/shimmer-android#86 Differential Revision: D16053297 Pulled By: xiphirx fbshipit-source-id: 9f50e1f56c1f2272fbb2da70dbea3680da6e03f1
overbomigu
added a commit
to overbomigu/imgur
that referenced
this pull request
Nov 22, 2025
Summary: PR for facebookarchive/shimmer-android#85 It doesn't seem like the best implementation since I'm just nulling the Shimmer but it does the job. I've tested this in the sample app by depending on the library project rather than the snapshot and added another button for toggling it on and off but haven't included any of that in this PR. If you would like me to I'll update it. Pull Request resolved: facebookarchive/shimmer-android#86 Differential Revision: D16053297 Pulled By: xiphirx fbshipit-source-id: 9f50e1f56c1f2272fbb2da70dbea3680da6e03f1
AstarLighte
added a commit
to AstarLighte/mixdown
that referenced
this pull request
Dec 16, 2025
Summary: PR for facebookarchive/shimmer-android#85 It doesn't seem like the best implementation since I'm just nulling the Shimmer but it does the job. I've tested this in the sample app by depending on the library project rather than the snapshot and added another button for toggling it on and off but haven't included any of that in this PR. If you would like me to I'll update it. Pull Request resolved: facebookarchive/shimmer-android#86 Differential Revision: D16053297 Pulled By: xiphirx fbshipit-source-id: 9f50e1f56c1f2272fbb2da70dbea3680da6e03f1
edsoftsae
added a commit
to edsoftsae/edsoftsae
that referenced
this pull request
Jan 4, 2026
Summary: PR for facebookarchive/shimmer-android#85 It doesn't seem like the best implementation since I'm just nulling the Shimmer but it does the job. I've tested this in the sample app by depending on the library project rather than the snapshot and added another button for toggling it on and off but haven't included any of that in this PR. If you would like me to I'll update it. Pull Request resolved: facebookarchive/shimmer-android#86 Differential Revision: D16053297 Pulled By: xiphirx fbshipit-source-id: 9f50e1f56c1f2272fbb2da70dbea3680da6e03f1
owpdoeir
added a commit
to owpdoeir/mmap_ringbuffer
that referenced
this pull request
Mar 27, 2026
Summary: PR for facebookarchive/shimmer-android#85 It doesn't seem like the best implementation since I'm just nulling the Shimmer but it does the job. I've tested this in the sample app by depending on the library project rather than the snapshot and added another button for toggling it on and off but haven't included any of that in this PR. If you would like me to I'll update it. Pull Request resolved: facebookarchive/shimmer-android#86 Differential Revision: D16053297 Pulled By: xiphirx fbshipit-source-id: 9f50e1f56c1f2272fbb2da70dbea3680da6e03f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #85
It doesn't seem like the best implementation since I'm just nulling the Shimmer but it does the job.
I've tested this in the sample app by depending on the library project rather than the snapshot and added another button for toggling it on and off but haven't included any of that in this PR. If you would like me to I'll update it.