This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Draw ShimmerDrawable mDrawRect at correct position#60
Closed
yarolegovich wants to merge 1 commit intofacebookarchive:masterfrom
yarolegovich:59-shimmer-position
Closed
Draw ShimmerDrawable mDrawRect at correct position#60yarolegovich wants to merge 1 commit intofacebookarchive:masterfrom yarolegovich:59-shimmer-position
yarolegovich wants to merge 1 commit intofacebookarchive:masterfrom
yarolegovich:59-shimmer-position
Conversation
After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position. Perform translation after rotation to fix the issue. re #59
facebook-github-bot
left a comment
There was a problem hiding this comment.
@xiphirx is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PoppyProses
added a commit
to PoppyProses/PoppyProses
that referenced
this pull request
Aug 20, 2025
Summary: After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position. Perform translation after rotation to fix the issue. re #59 Closes facebookarchive/shimmer-android#60 Differential Revision: D8728413 Pulled By: xiphirx fbshipit-source-id: b8b839fae2e9c91b4a5085e020460447bd6f7cad
FelixiReed
added a commit
to FelixiReed/monoap
that referenced
this pull request
Sep 17, 2025
Summary: After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position. Perform translation after rotation to fix the issue. re #59 Closes facebookarchive/shimmer-android#60 Differential Revision: D8728413 Pulled By: xiphirx fbshipit-source-id: b8b839fae2e9c91b4a5085e020460447bd6f7cad
overbomigu
added a commit
to overbomigu/imgur
that referenced
this pull request
Nov 22, 2025
Summary: After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position. Perform translation after rotation to fix the issue. re #59 Closes facebookarchive/shimmer-android#60 Differential Revision: D8728413 Pulled By: xiphirx fbshipit-source-id: b8b839fae2e9c91b4a5085e020460447bd6f7cad
AstarLighte
added a commit
to AstarLighte/mixdown
that referenced
this pull request
Dec 16, 2025
Summary: After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position. Perform translation after rotation to fix the issue. re #59 Closes facebookarchive/shimmer-android#60 Differential Revision: D8728413 Pulled By: xiphirx fbshipit-source-id: b8b839fae2e9c91b4a5085e020460447bd6f7cad
edsoftsae
added a commit
to edsoftsae/edsoftsae
that referenced
this pull request
Jan 4, 2026
Summary: After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position. Perform translation after rotation to fix the issue. re #59 Closes facebookarchive/shimmer-android#60 Differential Revision: D8728413 Pulled By: xiphirx fbshipit-source-id: b8b839fae2e9c91b4a5085e020460447bd6f7cad
owpdoeir
added a commit
to owpdoeir/mmap_ringbuffer
that referenced
this pull request
Mar 27, 2026
Summary: After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position. Perform translation after rotation to fix the issue. re #59 Closes facebookarchive/shimmer-android#60 Differential Revision: D8728413 Pulled By: xiphirx fbshipit-source-id: b8b839fae2e9c91b4a5085e020460447bd6f7cad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After translation, rotation pivot (width/2, height/2) doesn't correspond to the center of mDrawRect, which leads to an incorrect mDrawRect position.
Perform translation after rotation to fix the issue.
re #59