This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Use esprima-fb package instead of pointing at github#3
Merged
Conversation
|
Did you test - react-page on a fresh npm install? |
Author
|
Just did... looks like it's working! |
Author
There was a problem hiding this comment.
"semantic" - our esprima package tracks the harmony branch of esprima, but we wanted to meaningfully version. So we (@jeffmo & I) opted to do it this way. This lets us make breaking changes and push out a new version (2001.y.z) and then if esprima makes a breaking change that we merge in we can bump again (2002.y.z). Same goes for minor & patch levels.
jordwalke
added a commit
that referenced
this pull request
Aug 29, 2013
Use esprima-fb package instead of pointing at github
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better like this. No tests fail that didn't already (which is a thing we should fix).
I can just commit this directly to avoid a merge commit. Just give me the 👍