This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Closed
Conversation
Contributor
Author
Contributor
|
Can you re-trigger travis/appveyor to make sure failures are not related ? |
Contributor
Author
|
The tests don't actually run on TravisCI (see #550) - it just builds. Do they run on Appveyor? |
Contributor
Author
Contributor
|
@bwasti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 5, 2017
Summary: *Fix #417 again (#551 was insufficient)* Even after a reallocation, the data address can still be the same if malloc returns the same newly freed address. * Be very explicit and careful about how we set these flags so they don't interfere with other tests * Disable the failing check This somewhat takes the teeth out of this test, since it no longer verifies that the reallocation actually occurs. Test with: ``` blob_test --gtest_filter=TensorCPUTest*Shrink* \ --gtest_shuffle --gtest_repeat=100 --gtest_throw_on_failure ``` /cc sunwael Closes #723 Differential Revision: D5174953 Pulled By: akyrola fbshipit-source-id: 3d875a52c8139e73db85550817dea3c837eb7eae
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2017
Summary: See #723, #551, #417 ``` [ RUN ] TensorCPUTest/1.KeepOnShrink /opt/caffe2/caffe2/core/blob_test.cc:362: Failure Expected: (ptr) != (larger_ptr), actual: 0x24f7640 vs 0x24f7640 [ FAILED ] TensorCPUTest/1.KeepOnShrink, where TypeParam = int (0 ms) ``` I haven't been able to reproduce locally or on TravisCI - only in our own test infrastructure. The fix is conceptually the same as #723. After reading through the code, I can't see any other checks which should fail this way. Closes #801 Differential Revision: D5248106 Pulled By: akyrola fbshipit-source-id: 0cd3e2c11e7ae3d924496843a311530f0e08a9da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #417