Don't export private headers from Buck target (#37127)#1269
Closed
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Closed
Don't export private headers from Buck target (#37127)#1269NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 5c7aaf6c4e83ffe51ad1a59313eb5b518987a28e
2ac2a0a to
cddc994
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9520d3b4e8d7ace9aa039379d60b58a1ae1278fc
cddc994 to
c7a5b5d
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 28, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 29f1f31d15ea3f70bdca20ce5991e9f8c1fab4fe
c7a5b5d to
50223dc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 29, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 61d9b442a9a16a409da37c7ad6d5fa1b58922de9
50223dc to
0c6c8cf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 29, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: fbb7952f055568c635956bad2bdcf5110236beaa
0c6c8cf to
9946f36
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 29, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: bfeddda0a5c4c5cc2d88108475470948d2199406
9946f36 to
3a96740
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: f4bc57471ea99e74e9011c212ae46ff0b2c4a654
3a96740 to
84b7143
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 8a156e55368b4a3e896d93f6b43ed05477c37e8c
84b7143 to
dc4e53b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9a00c89c4d6ccfa33db7064c34b5cf5d400d58fe
dc4e53b to
60ac190
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 3, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 5b2fd84c6d1e23d32c31a1c5c59775a829b758fd
Contributor
|
This pull request has been merged in d8dec0f. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 3, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: #37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
May 3, 2023
Summary: X-link: facebook/yoga#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
This was referenced May 4, 2023
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
May 4, 2023
Summary: X-link: facebook/react-native#37242 X-link: facebook/yoga#1278 facebook/yoga#1269 broke building Yoga Buck targets with MSVC. The build logs suggest this is because headers may be double included from `exported_headers` and `headers`, causing redefinition. We are not saved on the MSVC build by `#pragma once` since headers are imported from different paths (but the Clang build seems okay with this). This diff attempts to isolate headers so that nothing may be double exported. This is done in a little bit of a tricky way, since Starlark doesn't seem to support globs in the form of `{a,b}`, and Yoga's directory structure does not separate public and private headers cleanly (we should fix this, but it needs to be changed in multiple build systems at once which I want to do not in this change). We also get a side effect that every file which isn't a public header needs to use the namespaced form to refer to a public header, even if in the same directory. Though this is going to be needed anyway if we end up wanting to move the public headers to a new directory. Reviewed By: yungsters Differential Revision: D45552325 fbshipit-source-id: 407fda6b062692c1016e157b066cac286c29ec49
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 4, 2023
Summary: X-link: facebook/react-native#37242 Pull Request resolved: facebook#1278 facebook#1269 broke building Yoga Buck targets with MSVC. The build logs suggest this is because headers may be double included from `exported_headers` and `headers`, causing redefinition. We are not saved on the MSVC build by `#pragma once` since headers are imported from different paths (but the Clang build seems okay with this). This diff attempts to isolate headers so that nothing may be double exported. This is done in a little bit of a tricky way, since Starlark doesn't seem to support globs in the form of `{a,b}`, and Yoga's directory structure does not separate public and private headers cleanly (we should fix this, but it needs to be changed in multiple build systems at once which I want to do not in this change). We also get a side effect that every file which isn't a public header needs to use the namespaced form to refer to a public header, even if in the same directory. Though this is going to be needed anyway if we end up wanting to move the public headers to a new directory. Reviewed By: yungsters Differential Revision: D45552325 fbshipit-source-id: f11852242c600044e4fb6da3aa7b522da248ca4b
liujinye-sys
pushed a commit
to open-vela/external_yoga
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: facebook/yoga#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#37127
This prevents targets which include Yoga from using its private APIs.
Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a
yoga-private-apitarget for now to keep using these headers while making it unlikely new usages will show up.Reviewed By: javache
Differential Revision: D45339425