[docs] fix confirm dialog closing when clicking inside#1439
Merged
vincentriemer merged 3 commits intofacebook:mainfrom Jan 6, 2026
Merged
[docs] fix confirm dialog closing when clicking inside#1439vincentriemer merged 3 commits intofacebook:mainfrom
vincentriemer merged 3 commits intofacebook:mainfrom
Conversation
|
@alexcarpenter is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
abhakat
pushed a commit
that referenced
this pull request
Feb 6, 2026
* [docs] fix dialog closing when clicking inside * sort keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
The confirm dialog was closing when clicking inside of the dialog due to padding usage being apart of the dialog. This PR adds a content element that applies the padding to prevent unintentionally closing.
Linked PR/Issues
Fixes # (issue)
Additional Context
BEFORE
before.mov
AFTER
after.mov
Screenshots, Tests, Anything Else
Pre-flight checklist
Contribution Guidelines