Fix clang anaylze warning caused by #6262#6641
Closed
siying wants to merge 1 commit intofacebook:masterfrom
Closed
Fix clang anaylze warning caused by #6262#6641siying wants to merge 1 commit intofacebook:masterfrom
siying wants to merge 1 commit intofacebook:masterfrom
Conversation
Summary: facebook#6262 causes CLANG analyze to complain. Add assertion to suppress the warning. Test Plan: Run "clang analyze" and make sure it passes.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
anand1976
approved these changes
Apr 3, 2020
Contributor
Author
|
Appveyor says pending but it actually succeeded. |
Contributor
|
This pull request has been merged in 00f8016. |
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
Nov 10, 2020
Summary: facebook#6262 causes CLANG analyze to complain. Add assertion to suppress the warning. Pull Request resolved: facebook#6641 Test Plan: Run "clang analyze" and make sure it passes. Reviewed By: anand1976 Differential Revision: D20841722 fbshipit-source-id: 5fa6e0c5cfe7a822214c9b898a408df59d4fd2cd Signed-off-by: tabokie <xy.tao@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#6262 causes CLANG analyze to complain. Add assertion to suppress the warning.
Test Plan: Run "clang analyze" and make sure it passes.