Disable folly_synchronization_distributed_mutex_test on ARM for now#6126
Closed
pdillinger wants to merge 1 commit intofacebook:masterfrom
Closed
Disable folly_synchronization_distributed_mutex_test on ARM for now#6126pdillinger wants to merge 1 commit intofacebook:masterfrom
pdillinger wants to merge 1 commit intofacebook:masterfrom
Conversation
Summary: This test is crashing on ARM but is not yet production code. Let's not let it block ARM CI. Test Plan: ./folly_synchronization_distributed_mutex_test, on Linux/ARM, on Linux/x86_64, and with LITE=1 on Linux/x86_64 (also disabled)
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
approved these changes
Dec 5, 2019
Contributor
|
@pdillinger merged this pull request in ad528fe. |
wolfkdy
pushed a commit
to wolfkdy/rocksdb
that referenced
this pull request
Dec 22, 2019
…acebook#6126) Summary: This test is crashing on ARM but is not yet production code. Let's not let it block ARM CI. See PR facebook#5932 Pull Request resolved: facebook#6126 Test Plan: ./folly_synchronization_distributed_mutex_test, on Linux/ARM, on Linux/x86_64, and with LITE=1 on Linux/x86_64 (also disabled) Differential Revision: D18836576 Pulled By: pdillinger fbshipit-source-id: d8a36eea2f048e8330411d994435d1c58a15d978
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This test is crashing on ARM but is not yet production code.
Let's not let it block ARM CI. See PR #5932
Test Plan: ./folly_synchronization_distributed_mutex_test, on Linux/ARM,
on Linux/x86_64, and with LITE=1 on Linux/x86_64 (also disabled)