Use SpecialSkipListFactory in RecalculateScoreAfterPicking#6125
Closed
pdillinger wants to merge 1 commit intofacebook:masterfrom
Closed
Use SpecialSkipListFactory in RecalculateScoreAfterPicking#6125pdillinger wants to merge 1 commit intofacebook:masterfrom
pdillinger wants to merge 1 commit intofacebook:masterfrom
Conversation
ajkr
reviewed
Dec 5, 2019
Summary: Test DBTestUniversalCompaction.RecalculateScoreAfterPicking was flaky on ARM, so it now uses SpecialSkipListFactory (like other tests) for predictable memtable flushes. Test Plan: while ./db_universal_compaction_test; do :; done # for a while on ARM and on Intel (both Linux)
ff23efb to
81cd62b
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ajkr
approved these changes
Dec 6, 2019
Contributor
ajkr
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing the comment. I think this way should lead to deterministic flushing decisions, in addition to the other benefits mentioned.
Contributor
|
@pdillinger merged this pull request in 3a6d943. |
wolfkdy
pushed a commit
to wolfkdy/rocksdb
that referenced
this pull request
Dec 22, 2019
…6125) Summary: Test DBTestUniversalCompaction.RecalculateScoreAfterPicking was flaky on ARM, so it now uses SpecialSkipListFactory (like other tests) for predictable memtable flushes. Fixes facebook#5736 Pull Request resolved: facebook#6125 Test Plan: while ./db_universal_compaction_test; do :; done # for a while on ARM and on Intel (both Linux) Differential Revision: D18864821 Pulled By: pdillinger fbshipit-source-id: 2f3ca0ea66ce420dcd6d41b0ec12377112a5a79f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Test DBTestUniversalCompaction.RecalculateScoreAfterPicking was
flaky on ARM, so it now uses SpecialSkipListFactory (like other tests)
for predictable memtable flushes.
Fixes #5736
Test Plan: while ./db_universal_compaction_test; do :; done # for a
while on ARM and on Intel (both Linux)