Fix BloomFilterPolicy changes for unsigned char (ARM)#6024
Closed
pdillinger wants to merge 1 commit intofacebook:masterfrom
Closed
Fix BloomFilterPolicy changes for unsigned char (ARM)#6024pdillinger wants to merge 1 commit intofacebook:masterfrom
pdillinger wants to merge 1 commit intofacebook:masterfrom
Conversation
Summary: Bug in PR facebook#5941 when char is unsigned that should only affect assertion on unused/invalid filter metadata. Test Plan: on ARM: ./bloom_test && ./db_bloom_filter_test && ./block_based_filter_block_test && ./full_filter_block_test && ./partitioned_filter_block_test
siying
approved these changes
Nov 12, 2019
siying
reviewed
Nov 12, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pdillinger is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pdillinger merged this pull request in 42b5494. |
pdillinger
added a commit
to pdillinger/rocksdb
that referenced
this pull request
Nov 13, 2019
merryChris
pushed a commit
to merryChris/rocksdb
that referenced
this pull request
Nov 18, 2019
Summary: Bug in PR facebook#5941 when char is unsigned that should only affect assertion on unused/invalid filter metadata. Pull Request resolved: facebook#6024 Test Plan: on ARM: ./bloom_test && ./db_bloom_filter_test && ./block_based_filter_block_test && ./full_filter_block_test && ./partitioned_filter_block_test Differential Revision: D18461206 Pulled By: pdillinger fbshipit-source-id: 68a7c813a0b5791c05265edc03cdf52c78880e9a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Bug in PR #5941 when char is unsigned that should only affect
assertion on unused/invalid filter metadata.
Test Plan: on ARM: ./bloom_test && ./db_bloom_filter_test && ./block_based_filter_block_test && ./full_filter_block_test && ./partitioned_filter_block_test