Conversation
| } | ||
| EOF | ||
| if [ "$?" = 0 ]; then | ||
| COMMON_FLAGS="$COMMON_FLAGS -DROCKSDB_SCHED_GETCPU_PRESENT" |
There was a problem hiding this comment.
Would you want to set it in build_tools/fbcode_config.sh and build_tools/fbcode_config4.8.1.sh too?
There was a problem hiding this comment.
do we still use those? I noticed our TARGETS file manually sets some of these like -DROCKSDB_FALLOCATE_PRESENT. Is adding it to TARGETS sufficient?
There was a problem hiding this comment.
oh never mind, I see why they're needed now.
There was a problem hiding this comment.
And you have a good point. You need to add it to TARGETS file too. I think we may also have missed several other flags there and TARGETS files.
|
@ajkr updated the pull request - view changes |
|
@ajkr updated the pull request - view changes |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| @@ -401,6 +401,17 @@ EOF | |||
| if [ "$?" = 0 ]; then | |||
| COMMON_FLAGS="$COMMON_FLAGS -DROCKSDB_RANGESYNC_PRESENT" | |||
There was a problem hiding this comment.
Damn, we need to add this one too before the next release.
Uh oh!
There was an error while loading. Please reload this page.