checkpoint.h: Add missing includes <cstdint>#11137
Open
kraj wants to merge 1 commit intofacebook:mainfrom
Open
checkpoint.h: Add missing includes <cstdint>#11137kraj wants to merge 1 commit intofacebook:mainfrom
kraj wants to merge 1 commit intofacebook:mainfrom
Conversation
It uses uint64_t and it comes from <cstdint> This is needed with GCC 13 and newer [1] [1] https://www.gnu.org/software/gcc/gcc-13/porting_to.html Signed-off-by: Khem Raj <raj.khem@gmail.com>
Contributor
|
Hi @kraj! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 8, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 8, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 8, 2023
This applies two patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies two patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies two patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Apr 19, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
May 10, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Aug 30, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Aug 30, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Mar 6, 2024
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It uses uint64_t and it comes from
This is needed with GCC 13 and newer [1]
[1] https://www.gnu.org/software/gcc/gcc-13/porting_to.html
Signed-off-by: Khem Raj raj.khem@gmail.com