This repository was archived by the owner on Feb 1, 2025. It is now read-only.
Allow the runtime to be required as a module, and make it strict-mode-compliant.#167
Merged
Allow the runtime to be required as a module, and make it strict-mode-compliant.#167
Conversation
Contributor
Sounds good to me. |
58a5350 to
9cb742a
Compare
|
Great, I'm excited by this change! I posted a comment on the commit that no longer appears to be there about the implicit global likely still violating strict mode. |
9cb742a to
0a40d0a
Compare
0a40d0a to
4b570c2
Compare
runtime-module.js
Outdated
4b570c2 to
0f2c4c5
Compare
benjamn
added a commit
that referenced
this pull request
Jan 14, 2015
Allow the runtime to be required as a module, and make it strict-mode-compliant.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sebmck @appden does this work for you?
I'm a little worried that this will be a breaking change for users who expect
regeneratorRuntimeto be defined globally for them. What if we kept defining it globally in https://github.com/facebook/regenerator/blob/master/runtime.js, but provided another file that you couldrequireas a proper module instead?Fixes #165.
Fixes #166.