Split up Docs and API#962
Merged
cpojer merged 1 commit intofacebook:masterfrom May 28, 2019
yangshun:sidebar-docs-api
Merged
Conversation
|
Deploy preview for react-native ready! Built with commit df009f5 https://deploy-preview-962--react-native.netlify.com Changes to Thank you for your contributions. |
cpojer
approved these changes
May 28, 2019
Contributor
cpojer
left a comment
There was a problem hiding this comment.
This is absolutely fantastic. Thank you so much! I'll work on an intro page for the API docs next.
82 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up of #934, by @cpojer
This PR splits up the Docs and API pages into two separate navigations.
Note that this only takes effect in the 0.59 docs onwards. We could technically go back and edit the sidebars for all the previous versions but not sure if it'll be worth it. I could do it the maintainers think it's necessary. But modifying old versions is not recommended and even I'm not sure what undesired consequences there will be.
Test Plan
Now there are two top-level entry points for docs-related content - Docs and API