Skip to content

Update Docusaurus to 1.9.0#934

Merged
rickhanlonii merged 1 commit intofacebook:masterfrom
yangshun:docusaurus
May 16, 2019
Merged

Update Docusaurus to 1.9.0#934
rickhanlonii merged 1 commit intofacebook:masterfrom
yangshun:docusaurus

Conversation

@yangshun
Copy link
Copy Markdown
Contributor

@yangshun yangshun commented May 16, 2019

Summary

  • Update Docusaurus to 1.9.0
  • Enable collapsible side bar
  • Clean up some hrefs that were pointing to .html extensions. This should have been done when the cleanUrl option was enabled but it still works because we generate both /path/index.html and /path.html in v1. This will break in v2 so better change it now.
  • Enable the scroll-to-top button

Screen Shot 2019-05-16 at 11 53 26 AM

@react-native-bot
Copy link
Copy Markdown

react-native-bot commented May 16, 2019

Deploy preview for react-native ready!

Built with commit cd86475

https://deploy-preview-934--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

@rickhanlonii
Copy link
Copy Markdown
Member

rickhanlonii commented May 16, 2019

Whaaaat, thanks @yangshun!

@rickhanlonii rickhanlonii merged commit f613fce into facebook:master May 16, 2019
@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented May 17, 2019

Thanks so much @yangshun, this is so much better :)

I'm wondering if there is a way to split up the Docs and API pages into two separate top-level entry points both with their own sidebars? For Docs, it should only have the Guides sections and for API it should have the Components and API sections. Is this possible?

@cpojer cpojer mentioned this pull request May 17, 2019
Closed
82 tasks
@charpeni
Copy link
Copy Markdown
Contributor

charpeni commented May 17, 2019

Thank you, @yangshun!

@yangshun yangshun deleted the docusaurus branch May 17, 2019 16:27
@yangshun
Copy link
Copy Markdown
Contributor Author

yangshun commented May 17, 2019 •
edited
Loading

Welcome! I'm always available to answer any Docusaurus-specific questions. Cheers! 🎉

I'm wondering if there is a way to split up the Docs and API pages into two separate top-level entry points both with their own sidebars? For Docs, it should only have the Guides sections and for API it should have the Components and API sections. Is this possible?

I think it should be. I'll look into that.

@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented May 21, 2019

I just noticed that this also collapses the sidebar in the blog section. Is it possible to always expand it there?

@yangshun
Copy link
Copy Markdown
Contributor Author

yangshun commented May 22, 2019

This is a limitation of the collapsible sidebar. I'll modify Docusaurus core to not collapse for blogs.

@yangshun yangshun mentioned this pull request May 26, 2019
Merged
@yangshun
Copy link
Copy Markdown
Contributor Author

yangshun commented May 26, 2019

PR for the fix in facebook/docusaurus#1519. Will update RN website when that PR is merged.

This was referenced May 26, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

p: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yangshun @react-native-bot @rickhanlonii @cpojer @charpeni @facebook-github-bot