Skip to content

fix grammar - add 'will'#1637

Merged
nearestnabors merged 2 commits intofacebook:masterfrom
mr-islam:patch-1
Feb 17, 2020
Merged

fix grammar - add 'will'#1637
nearestnabors merged 2 commits intofacebook:masterfrom
mr-islam:patch-1

Conversation

@mr-islam
Copy link
Copy Markdown
Contributor

Hi,

Just wanted to point out a tiny word that was missing in the docs that messed up the grammar.

The page on Share currently states:

In Android, Returns a Promise which always be resolved with action being Share.sharedAction.

This PR adds the word will to the above sentence, leading to this improved sentence:

In Android, Returns a Promise which will always be resolved with action being Share.sharedAction.

It's a small issue but having perfect docs is always nice :)

@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Feb 17, 2020

Deploy preview for react-native ready!

Built with commit 5be4e8c

https://deploy-preview-1637--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Even more perfect grammar ;)
@nearestnabors
Copy link
Copy Markdown
Contributor

nearestnabors commented Feb 17, 2020

We agree! Good grammar also makes it easier to use automatic translation services. Thank you for your vigilance! Hope to see you in the PR queue again!

@nearestnabors nearestnabors merged commit 9d4dcdb into facebook:master Feb 17, 2020
kaioduarte pushed a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
* fix grammar - add 'will'

* Update share.md

Even more perfect grammar ;)

Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants